update tests and export

Author: paula-stacho

packages/compass-schema-validation/src/components/document-preview.spec.tsx

@@ -5,37 +5,14 @@ import { expect } from 'chai';
 import { DocumentPreview } from './document-preview';
 
 describe('DocumentPreview [Component]', function () {
-  context('when document loading state is initial', function () {
-    it('renders a button to load a sample document', function () {
-      const component = mount(<DocumentPreview loadingState="initial" />);
-      expect(component.find('[data-testid="load-sample-document"]')).to.exist;
-    });
-  });
-
-  context('when document loading state is loading', function () {
-    it('renders a spinner', function () {
-      const component = mount(<DocumentPreview loadingState="loading" />);
-      expect(component.find('[data-testid="load-sample-spinner"]')).to.exist;
-    });
-  });
-
   context('when document loading state is success', function () {
     it('renders a document if there is one present', function () {
-      const component = mount(
-        <DocumentPreview loadingState="success" document={{}} />
-      );
+      const component = mount(<DocumentPreview document={{}} />);
       expect(component.find('HadronDocument')).to.exist;
     });
 
     it('renders a no preview text when there is no document', function () {
-      const component = mount(<DocumentPreview loadingState="success" />);
-      expect(component).to.have.text('No Preview Documents');
-    });
-  });
-
-  context('when document loading state is error', function () {
-    it('renders a no preview text', function () {
-      const component = mount(<DocumentPreview loadingState="error" />);
+      const component = mount(<DocumentPreview />);
       expect(component).to.have.text('No Preview Documents');
     });
   });

packages/compass-schema-validation/src/modules/sample-documents.spec.ts

@@ -4,18 +4,17 @@ import reducer, {
   INITIAL_STATE,
   CLEAR_SAMPLE_DOCUMENTS,
   clearSampleDocuments,
-  fetchingValidDocument,
-  FETCHING_VALID_DOCUMENT,
   fetchedValidDocument,
   FETCHED_VALID_DOCUMENT,
-  fetchingInvalidDocument,
-  FETCHING_INVALID_DOCUMENT,
   fetchedInvalidDocument,
   FETCHED_INVALID_DOCUMENT,
   fetchingValidDocumentFailed,
   FETCHING_INVALID_DOCUMENT_FAILED,
   fetchingInvalidDocumentFailed,
   FETCHING_VALID_DOCUMENT_FAILED,
+  fetchingSampleDocuments,
+  FETCHING_SAMPLE_DOCUMENTS,
+  type SampleDocumentState,
 } from './sample-documents';
 
 const SAMPLE_DOCUMENT = {
@@ -31,14 +30,8 @@ describe('sample-documents module', function () {
     });
 
     it('returns the FETCHING_VALID_DOCUMENT action', function () {
-      expect(fetchingValidDocument()).to.deep.equal({
-        type: FETCHING_VALID_DOCUMENT,
-      });
-    });
-
-    it('returns the FETCHING_INVALID_DOCUMENT action', function () {
-      expect(fetchingInvalidDocument()).to.deep.equal({
-        type: FETCHING_INVALID_DOCUMENT,
+      expect(fetchingSampleDocuments()).to.deep.equal({
+        type: FETCHING_SAMPLE_DOCUMENTS,
       });
     });
 
@@ -93,66 +86,72 @@ describe('sample-documents module', function () {
       });
     });
 
-    context('when the action is FETCHING_VALID_DOCUMENT', function () {
+    context('when the action is FETCHING_SAMPLE_DOCUMENTS', function () {
       it('returns a loading state', function () {
-        const sampleDocuments = reducer(undefined, fetchingValidDocument());
+        const sampleDocuments = reducer(undefined, fetchingSampleDocuments());
         expect(sampleDocuments.validDocumentState).to.equal('loading');
+        expect(sampleDocuments.invalidDocumentState).to.equal('loading');
       });
     });
 
-    context('when the action is FETCHING_INVALID_DOCUMENT', function () {
-      it('returns a loading state', function () {
-        const sampleDocuments = reducer(undefined, fetchingInvalidDocument());
-        expect(sampleDocuments.invalidDocumentState).to.equal('loading');
+    context('fetch results', function () {
+      let loadingState: SampleDocumentState;
+      beforeEach(function () {
+        loadingState = reducer(undefined, fetchingSampleDocuments());
       });
-    });
 
-    context('when the action is FETCHED_VALID_DOCUMENT', function () {
-      it('updates the state with the document', function () {
-        for (const document of [null, undefined, SAMPLE_DOCUMENT] as any[]) {
-          const sampleDocuments = reducer(
-            undefined,
-            fetchedValidDocument(document)
-          );
-          expect(sampleDocuments.validDocumentState).to.equal('success');
-          expect(sampleDocuments.validDocument).to.deep.equal(document);
-        }
+      context('when the action is FETCHED_VALID_DOCUMENT', function () {
+        it('updates the state with the document', function () {
+          for (const document of [null, undefined, SAMPLE_DOCUMENT] as any[]) {
+            const sampleDocuments = reducer(
+              loadingState,
+              fetchedValidDocument(document)
+            );
+            expect(sampleDocuments.validDocumentState).to.equal('success');
+            expect(sampleDocuments.validDocument).to.deep.equal(document);
+            expect(sampleDocuments.invalidDocumentState).to.equal('loading');
+          }
+        });
       });
-    });
 
-    context('when the action is FETCHED_INVALID_DOCUMENT', function () {
-      it('updates the state with the document', function () {
+      context('when the action is FETCHED_INVALID_DOCUMENT', function () {
         for (const document of [null, undefined, SAMPLE_DOCUMENT] as any[]) {
           const sampleDocuments = reducer(
-            undefined,
+            loadingState,
             fetchedInvalidDocument(document)
           );
           expect(sampleDocuments.invalidDocumentState).to.equal('success');
           expect(sampleDocuments.invalidDocument).to.deep.equal(document);
+          expect(sampleDocuments.validDocumentState).to.equal('loading');
         }
       });
-    });
 
-    context('when the action is FETCHING_VALID_DOCUMENT_FAILED', function () {
-      it('updates an error state', function () {
-        const sampleDocuments = reducer(
-          undefined,
-          fetchingValidDocumentFailed()
-        );
-        expect(sampleDocuments.validDocumentState).to.equal('error');
-        expect(sampleDocuments.validDocument).to.equal(undefined);
+      context('when the action is FETCHING_VALID_DOCUMENT_FAILED', function () {
+        it('updates an error state', function () {
+          const sampleDocuments = reducer(
+            loadingState,
+            fetchingValidDocumentFailed()
+          );
+          expect(sampleDocuments.validDocumentState).to.equal('error');
+          expect(sampleDocuments.validDocument).to.equal(undefined);
+          expect(sampleDocuments.invalidDocumentState).to.equal('loading');
+        });
       });
-    });
 
-    context('when the action is FETCHING_INVALID_DOCUMENT_FAILED', function () {
-      it('updates an error state', function () {
-        const sampleDocuments = reducer(
-          undefined,
-          fetchingInvalidDocumentFailed()
-        );
-        expect(sampleDocuments.invalidDocumentState).to.equal('error');
-        expect(sampleDocuments.invalidDocument).to.deep.equal(undefined);
-      });
+      context(
+        'when the action is FETCHING_INVALID_DOCUMENT_FAILED',
+        function () {
+          it('updates an error state', function () {
+            const sampleDocuments = reducer(
+              loadingState,
+              fetchingInvalidDocumentFailed()
+            );
+            expect(sampleDocuments.invalidDocumentState).to.equal('error');
+            expect(sampleDocuments.invalidDocument).to.deep.equal(undefined);
+            expect(sampleDocuments.validDocumentState).to.equal('loading');
+          });
+        }
+      );
     });
   });
 });

packages/compass-schema-validation/src/modules/sample-documents.ts

@@ -74,13 +74,17 @@ interface FetchingInvalidDocumentFailedAction {
   type: typeof FETCHING_INVALID_DOCUMENT_FAILED;
 }
 
-export type SampleDocumentNonInitialAction =
+type SampleDocumentNonInitialAction =
   | ClearSampleDocumentsAction
   | FetchedValidDocumentAction
   | FetchedInvalidDocumentAction
   | FetchingInvalidDocumentFailedAction
   | FetchingValidDocumentFailedAction;
 
+export type SampleDocumentAction =
+  | SampleDocumentNonInitialAction
+  | FetchingSampleDocumentsAction;
+
 /**
  * Action creators
  */

packages/compass-schema-validation/src/stores/store.spec.ts

@@ -9,10 +9,7 @@ import {
   validationActionChanged,
   validationLevelChanged,
 } from '../modules/validation';
-import {
-  fetchValidDocument,
-  fetchInvalidDocument,
-} from '../modules/sample-documents';
+import { fetchSampleDocuments } from '../modules/sample-documents';
 import { stringify as javascriptStringify } from 'javascript-stringify';
 import type { Store } from 'redux';
 import type { RootAction, RootState } from '../modules';
@@ -157,7 +154,7 @@ describe('Schema Validation Store', function () {
       });
     });
 
-    context('when the action is fetch valid sample documents', function () {
+    context('when the action is fetch sample documents', function () {
       it('updates the sample document loading in state', function (done) {
         expect(store.getState().sampleDocuments.validDocumentState).to.equal(
           'initial'
@@ -167,25 +164,12 @@ describe('Schema Validation Store', function () {
           expect(store.getState().sampleDocuments.validDocumentState).to.equal(
             'loading'
           );
-          done();
-        });
-        store.dispatch(fetchValidDocument() as any);
-      });
-    });
-
-    context('when the action is fetch invalid sample documents', function () {
-      it('updates the sample document loading in state', function (done) {
-        expect(store.getState().sampleDocuments.invalidDocumentState).to.equal(
-          'initial'
-        );
-        const unsubscribe = store.subscribe(() => {
-          unsubscribe();
           expect(
             store.getState().sampleDocuments.invalidDocumentState
           ).to.equal('loading');
           done();
         });
-        store.dispatch(fetchInvalidDocument() as any);
+        store.dispatch(fetchSampleDocuments() as any);
       });
     });