Simplified tsconfigs

Author: kraenhansen

packages/compass-e2e-tests/helpers/compass-web-sandbox.ts

@@ -1,3 +1,5 @@
+import assert from 'node:assert/strict';
+
 import crossSpawn from 'cross-spawn';
 import { remote } from 'webdriverio';
 import Debug from 'debug';
@@ -171,12 +173,16 @@ export async function spawnCompassWebSandboxAndSignInToAtlas(
   }
 
   const res = settledRes.value;
+  assert(
+    res.ok,
+    `Failed to authenticate in Atlas Cloud: ${res.statusText} (${res.status})`
+  );
 
-  if (res.ok === false || !(await res.json()).projectId) {
-    throw new Error(
-      `Failed to authenticate in Atlas Cloud: ${res.statusText} (${res.status})`
-    );
-  }
+  const body = await res.json();
+  assert(
+    typeof body === 'object' && body !== null && 'projectId' in body,
+    'Expected a project id'
+  );
 
   if (signal.aborted) {
     return electronProxyRemote;

packages/compass-e2e-tests/package.json

@@ -5,7 +5,7 @@
   "description": "E2E test suite for Compass app that follows smoke tests / feature testing matrix",
   "scripts": {
     "clean": "node -e \"try { fs.rmdirSync('.mongodb', { recursive: true }); } catch (e) {}\" && node -e \"try { fs.rmdirSync('.log', { recursive: true }); } catch (e) {}\"",
-    "typecheck": "tsc -p tsconfig-lint.json --noEmit",
+    "typecheck": "tsc -p tsconfig.json",
     "eslint": "eslint",
     "prettier": "prettier",
     "lint": "npm run typecheck && npm run eslint . && npm run prettier -- --check .",

packages/compass-e2e-tests/tsconfig-lint.json

@@ -1,4 +1,7 @@
 {
   "extends": "@mongodb-js/tsconfig-compass/tsconfig.common.json",
-  "compilerOptions": {}
+  "compilerOptions": {
+    "noEmit": true
+  },
+  "include": ["helpers", "installers", "tests", "*.ts"]
 }