Skip to content

Commit 9592cad

Browse files
committed
removed dependency on data for ui update
1 parent c458501 commit 9592cad

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

src/minicharts/querybuilder.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -81,10 +81,11 @@ module.exports = {
8181
* update the UI after a distinct query and mark appropriate elements with .select class.
8282
* @param {Object} data data object of the event
8383
*/
84-
updateUI_distinct: function(data) {
84+
updateUI_distinct: function() {
85+
debug('update ui distinct');
8586
var uiElements = this.queryAll('.selectable');
8687
_.each(uiElements, function(el) {
87-
var elData = data.source === 'unique' ? el.innerText : d3.select(el).data()[0].value;
88+
var elData = el.innerText || d3.select(el).data()[0].value;
8889
if (_.contains(_.pluck(this.selectedValues, 'value'), elData)) {
8990
el.classList.add('selected');
9091
el.classList.remove('unselected');
@@ -265,10 +266,11 @@ module.exports = {
265266
// now call appropriate event handlers and query build methods
266267
if (data.type === 'drag') {
267268
this.handleEvent_drag();
269+
this['buildQuery_' + queryType]();
268270
} else {
269271
this['handleEvent_' + queryType](data);
272+
this['buildQuery_' + queryType]();
273+
this['updateUI_' + queryType]();
270274
}
271-
this['buildQuery_' + queryType]();
272-
this['updateUI_' + queryType](data);
273275
}
274276
};

0 commit comments

Comments
 (0)