make it clear that this is for search-related stages only

Author: lerouxb

packages/compass-aggregations/src/components/focus-mode/focus-mode-stage-preview.tsx

@@ -16,6 +16,7 @@ import OutputStagePreview from '../stage-preview/output-stage-preview';
 import { AtlasStagePreview } from '../stage-preview/atlas-stage-preview';
 import {
   isAtlasOnlyStage,
+  isSearchStage,
   isMissingAtlasStageSupport,
   isOutputStage,
 } from '../../utils/stage';
@@ -24,7 +25,7 @@ import {
   expandPreviewDocsForStage,
 } from '../../modules/pipeline-builder/stage-editor';
 import type { StoreStage } from '../../modules/pipeline-builder/stage-editor';
-import AtlasNoResults from '../atlas-no-results';
+import SearchNoResults from '../search-no-results';
 
 const containerStyles = css({
   display: 'flex',
@@ -150,8 +151,8 @@ export const FocusModePreview = ({
         className={documentListStyles}
       />
     );
-  } else if (isAtlasOnlyStage(stageOperator)) {
-    content = <AtlasNoResults />;
+  } else if (isSearchStage(stageOperator)) {
+    content = <SearchNoResults />;
   } else {
     content = (
       <div className={centerStyles}>

packages/compass-aggregations/src/components/pipeline-builder-workspace/pipeline-as-text-workspace/pipeline-preview.tsx

@@ -25,7 +25,7 @@ import {
   expandPreviewDocs,
   collapsePreviewDocs,
 } from '../../../modules/pipeline-builder/text-editor-pipeline';
-import AtlasNoResults from '../../atlas-no-results';
+import SearchNoResults from '../../search-no-results';
 
 const containerStyles = css({
   display: 'flex',
@@ -128,7 +128,7 @@ const PreviewResults = ({
 
   if (previewDocs.length === 0) {
     if (atlasOperator) {
-      return <AtlasNoResults />;
+      return <SearchNoResults />;
     }
     return (
       <div className={centerStyles}>

packages/compass-aggregations/src/components/atlas-no-results.tsx renamed to packages/compass-aggregations/src/components/search-no-results.tsx

@@ -27,7 +27,7 @@ const missingAtlasIndexDarkStyles = css({
   color: palette.green.base,
 });
 
-export default function AtlasNoResults() {
+export default function SearchNoResults() {
   const darkMode = useDarkMode();
 
   return (

packages/compass-aggregations/src/components/stage-preview/index.tsx

@@ -14,7 +14,7 @@ import { Document } from '@mongodb-js/compass-crud';
 
 import type { RootState } from '../../modules';
 import {
-  isAtlasOnlyStage,
+  isSearchStage,
   isMissingAtlasStageSupport,
   isOutputStage,
 } from '../../utils/stage';
@@ -25,7 +25,7 @@ import OutputStagePreivew from './output-stage-preview';
 import StagePreviewHeader from './stage-preview-header';
 import type { StoreStage } from '../../modules/pipeline-builder/stage-editor';
 
-import AtlasNoResults from '../atlas-no-results';
+import SearchNoResults from '../search-no-results';
 
 const centeredContent = css({
   display: 'flex',
@@ -145,8 +145,8 @@ function StagePreviewBody({
     );
   }
 
-  if (isAtlasOnlyStage(stageOperator ?? '') && documents?.length === 0) {
-    return <AtlasNoResults />;
+  if (isSearchStage(stageOperator) && documents?.length === 0) {
+    return <SearchNoResults />;
   }
 
   if (documents && documents.length > 0) {

packages/compass-aggregations/src/utils/stage.ts

@@ -203,6 +203,21 @@ export function isAtlasOnlyStage(
   return !!stageOperator && ATLAS_ONLY_OPERATOR_NAMES.has(stageOperator);
 }
 
+/*
+Atlas Search does not return an error if there is no search index - it just
+returns no results. So if the connection has access to Atlas Search and the
+aggregation used a search-related stage and got no results we want to display a
+different error.
+*/
+export function isSearchStage(
+  stageOperator: string | null | undefined
+): stageOperator is '$search' | '$searchMeta' | '$vectorSearch' {
+  if (!stageOperator) {
+    return false;
+  }
+  return ['$search', '$searchMeta', '$vectorSearch'].includes(stageOperator);
+}
+
 const STAGE_OPERATORS_MAP = new Map(
   STAGE_OPERATORS.map((stage) => [stage.value, stage])
 );