Skip to content

Commit 9951185

Browse files
committed
INT-1280 fix Windows signing
Make the signtool.exe sitting in our current working directory executable. Remove the copy to electron-winstaller's vendor directory. In Squirrel.Windows/src/Update/Program.cs, function signPEFile: search order for "signtool.exe" is: - first: ".\signtool.exe" - second: GetExecutingAssembly().Location - "Run down PATH and hope for the best" source: https://github.com/Squirrel/Squirrel.Windows/blob/b814ada81a0060be22ec2f24efb6be0ff8c16d95/src/Update/Program.cs#L577-L588
1 parent 61386d0 commit 9951185

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

.evergreen.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,7 @@ functions:
8989
-o "signtool.exe" \
9090
--url "https://s3.amazonaws.com/boxes.10gen.com/build/signtool.exe"
9191
rm -f node_modules/electron-winstaller/vendor/signtool.exe
92-
cp signtool.exe node_modules/electron-winstaller/vendor/signtool.exe
93-
chmod +x node_modules/electron-winstaller/vendor/signtool.exe
92+
chmod +x signtool.exe
9493
9594
# Environment variables set for use by notary-service signtool.exe on Windows:
9695
# NOTARY_URL, NOTARY_AUTH_TOKEN, NOTARY_SIGNING_KEY, NOTARY_SIGNING_COMMENT

0 commit comments

Comments
 (0)