COMPASS-251 COMPASS-252 COMPASS-253: Guarding Write Operations (#581)

* Guard against write operations:

COMPASS-251, COMPASS-252, COMPASS-253: Doesn't allow user to perform
CRUD or DDL operations when the server is not writable or the view is
readonly.

* Fix tests

Author: durran

src/internal-packages/app/lib/stores/collection-store.js

@@ -1,3 +1,4 @@
+const app = require('ampersand-app');
 const Reflux = require('reflux');
 const { NamespaceStore } = require('hadron-reflux-store');
 
@@ -10,8 +11,7 @@ const CollectionStore = Reflux.createStore({
    * Initialize the store.
    */
   init() {
-    this.ns = null;
-    this.readonly = null;
+    this.collection = {};
   },
 
   /**
@@ -20,11 +20,37 @@ const CollectionStore = Reflux.createStore({
    * @param {Object} collection - The collection info.
    */
   setCollection(collection) {
-    this.ns = collection._id;
-    this.readonly = collection.readonly;
+    this.collection = collection;
     if (collection._id) {
-      NamespaceStore.ns = this.ns;
+      NamespaceStore.ns = collection._id;
     }
+  },
+
+  /**
+   * Get the collection ns.
+   *
+   * @returns {String} The collection ns.
+   */
+  ns() {
+    return this.collection._id;
+  },
+
+  /**
+   * Is the collection readonly?
+   *
+   * @returns {Boolean} If the collection is readonly.
+   */
+  isReadonly() {
+    return this.collection.readonly;
+  },
+
+  /**
+   * Is the collection writable?
+   *
+   * @returns {Boolean} If the collection is writable.
+   */
+  isWritable() {
+    return !this.isReadonly() && app.dataService.isWritable();
   }
 });
 

src/internal-packages/collection-stats/lib/store/index.js

@@ -30,7 +30,7 @@ const CollectionStatsStore = Reflux.createStore({
    */
   loadCollectionStats: function(ns) {
     if (toNS(ns || '').collection) {
-      if (this.CollectionStore.readonly) {
+      if (this.CollectionStore.isReadonly()) {
         this.trigger();
       } else {
         app.dataService.collection(ns, { readPreference: READ }, (err, result) => {

src/internal-packages/crud/lib/component/document-list.jsx

@@ -220,11 +220,10 @@ class DocumentList extends React.Component {
    * @return {Array} The document list item components.
    */
   renderDocuments(docs) {
-    const editable = app.dataService.isWritable() && !this.CollectionStore.readonly;
     return _.map(docs, (doc) => {
       return (
         <li className="document-list-item" key={this._key()}>
-          <Document doc={doc} key={this._key(doc)} editable={editable} />
+          <Document doc={doc} key={this._key(doc)} editable={this.CollectionStore.isWritable()} />
         </li>
       );
     });

src/internal-packages/database/lib/components/collections-table.jsx

@@ -38,13 +38,16 @@ class CollectionsTable extends React.Component {
       });
     });
 
+    const writable = app.dataService.isWritable();
+
     return (
       <div className="collections-table">
         <div className="collections-table-create-button">
-          <TextButton
-            text="Create Collection"
-            className="btn btn-default btn-sm"
-            clickHandler={this.onCreateCollectionButtonClicked.bind(this)} />
+          {writable ?
+            <TextButton
+              text="Create Collection"
+              className="btn btn-default btn-sm"
+              clickHandler={this.onCreateCollectionButtonClicked.bind(this)} /> : null}
         </div>
         <this.SortableTable
           theme="light"
@@ -54,7 +57,7 @@ class CollectionsTable extends React.Component {
           sortOrder={this.props.sortOrder}
           sortColumn={this.props.sortColumn}
           valueIndex={0}
-          removable
+          removable={writable}
           onColumnHeaderClicked={this.onColumnHeaderClicked.bind(this)}
           onRowDeleteButtonClicked={this.onRowDeleteButtonClicked.bind(this)}
         />

src/internal-packages/explain/lib/components/compass-explain.jsx

@@ -73,7 +73,7 @@ class CompassExplain extends React.Component {
     return (
       <div className="compass-explain header-margin">
         <div className="flexbox-fix"></div>
-        {this.CollectionStore.readonly ? this.renderReadonly() : this.renderComponent()}
+        {this.CollectionStore.isReadonly() ? this.renderReadonly() : this.renderComponent()}
       </div>
     );
   }

src/internal-packages/explain/lib/stores/index.js

@@ -123,7 +123,7 @@ const CompassExplainStore = Reflux.createStore({
     if (!ns.database || !ns.collection) {
       return;
     }
-    if (this.CollectionStore.readonly) {
+    if (this.CollectionStore.isReadonly()) {
       this.setState(this.getInitialState());
     } else {
       app.dataService.explain(ns.ns, filter, options, (err, explain) => {

src/internal-packages/indexes/lib/component/index-header.jsx

@@ -18,6 +18,7 @@ class IndexHeader extends React.Component {
   constructor(props) {
     super(props);
     this.state = { sortOrder: ASC };
+    this.CollectionStore = app.appRegistry.getStore('App.CollectionStore');
   }
 
   /**
@@ -59,7 +60,7 @@ class IndexHeader extends React.Component {
           <IndexHeaderColumn hook="th-size" name="Size" sortOrder={this.state.sortOrder} />
           <IndexHeaderColumn hook="th-usage" name="Usage" sortOrder={this.state.sortOrder} />
           <IndexHeaderColumn hook="th-properties" name="Properties" sortOrder={this.state.sortOrder} />
-          {app.dataService.isWritable() ?
+          {this.CollectionStore.isWritable() ?
             <IndexHeaderColumn hook="th-drop" name="Drop" sortOrder={this.state.sortOrder}/>
             : null}
         </tr>

src/internal-packages/indexes/lib/component/index.jsx

@@ -12,6 +12,11 @@ const app = require('ampersand-app');
  */
 class Index extends React.Component {
 
+  constructor(props) {
+    super(props);
+    this.CollectionStore = app.appRegistry.getStore('App.CollectionStore');
+  }
+
   /**
    * Render the index.
    *
@@ -27,7 +32,7 @@ class Index extends React.Component {
           relativeSize={this.props.index.relativeSize} />
         <UsageColumn usage={this.props.index.usageCount} since={this.props.index.usageSince} />
         <PropertyColumn index={this.props.index} />
-        {app.dataService.isWritable() ?
+        {this.CollectionStore.isWritable() ?
           <DropColumn indexName={this.props.index.name} />
           : null}
       </tr>

src/internal-packages/indexes/lib/component/indexes.jsx

@@ -36,8 +36,10 @@ class Indexes extends React.Component {
   }
 
   determineState() {
-    const writable = app.dataService.isWritable() && !this.CollectionStore.readonly;
-    return { writable: writable, readonly: this.CollectionStore.readonly };
+    return {
+      writable: this.CollectionStore.isWritable(),
+      readonly: this.CollectionStore.isReadonly()
+    };
   }
 
   handleLoad() {

src/internal-packages/indexes/lib/store/load-indexes-store.js

@@ -29,7 +29,7 @@ const LoadIndexesStore = Reflux.createStore({
    */
   loadIndexes: function() {
     if (NamespaceStore.ns) {
-      if (this.CollectionStore.readonly) {
+      if (this.CollectionStore.isReadonly()) {
         this.trigger([]);
       } else {
         app.dataService.indexes(NamespaceStore.ns, { readPreference: READ }, (err, indexes) => {