fix(proxy): do not lock users out of Compass when using authenticated proxies COMPASS-8382

Author: addaleax

packages/compass-settings/src/components/settings/proxy-settings-custom.tsx

@@ -1,4 +1,5 @@
 import {
+  Banner,
   Description,
   FormFieldContainer,
   Label,
@@ -197,6 +198,12 @@ export const ProxySettingsCustom: React.FunctionComponent<
           disabled={disabled}
         />
       </FormFieldContainer>
+      {(proxyPassword || proxyUsername) && (
+        <Banner variant="warning">
+          Some resources, such as map data for geographic visualizations, cannot
+          currently be loaded through proxies which require authentication.
+        </Banner>
+      )}
     </div>
   );
 };

packages/compass/src/main/application.ts

@@ -323,19 +323,7 @@ class CompassApplication {
               error: headline,
             }
           );
-
-          const sep = path.sep;
-          const configPath = `${app.getPath(
-            'userData'
-          )}${sep}AppPreferences${sep}General.json`;
-
-          dialog.showErrorBox(
-            'Unsupported proxy configuration',
-            `${headline}\n\n
-            To reset the proxy configuration, remove the "proxy" key in ${configPath} and restart Compass.`
-          );
-
-          app.quit();
+          await target.setProxy({});
         }
 
         const agent = createAgent(proxyOptions);