fix: do not replace tabs of different connections COMPASS-8113 (#6094)

Author: paula-stacho

packages/compass-workspaces/src/stores/workspaces.spec.ts

@@ -142,6 +142,21 @@ describe('tabs behavior', function () {
       expect(state).to.have.property('activeTabId', state.tabs[1].id);
     });
 
+    it('when the connection differs from the active tab, it should open a workspace in new tab', function () {
+      const store = configureStore();
+      store.dispatch(
+        openWorkspace({ type: 'Databases', connectionId: 'connectionA' })
+      );
+      store.dispatch(
+        openWorkspace({ type: 'Databases', connectionId: 'connectionB' })
+      );
+      const state = store.getState();
+      expect(state).to.have.property('tabs').have.lengthOf(2);
+      expect(state).to.have.nested.property('tabs[0].type', 'Databases');
+      expect(state).to.have.nested.property('tabs[1].type', 'Databases');
+      expect(state).to.have.property('activeTabId', state.tabs[1].id);
+    });
+
     it('should select already opened tab when trying to open a new one with the same attributes', function () {
       const store = configureStore();
       openTabs(store);

packages/compass-workspaces/src/stores/workspaces.ts

@@ -318,10 +318,23 @@ const reducer: Reducer<WorkspacesState> = (
           : state;
       }
 
-      // ... otherwise check if we can replace the current tab based on its
-      // replace handlers and force new tab opening if we can't
       if (currentActiveTab) {
-        forceNewTab = canReplaceTab(currentActiveTab) === false;
+        // if both the new workspace and the existing one are connection scoped,
+        // make sure we do not replace tabs between different connections
+        if (
+          action.workspace.type !== 'Welcome' &&
+          action.workspace.type !== 'My Queries' &&
+          currentActiveTab.type !== 'Welcome' &&
+          currentActiveTab.type !== 'My Queries'
+        ) {
+          forceNewTab =
+            action.workspace.connectionId !== currentActiveTab.connectionId;
+        }
+
+        // ... check if we can replace the current tab based on its
+        // replace handlers and force new tab opening if we can't
+        if (!forceNewTab)
+          forceNewTab = canReplaceTab(currentActiveTab) === false;
       }
     }