Skip to content

Commit a4344d6

Browse files
committed
.
1 parent 2ba7e14 commit a4344d6

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

packages/compass-e2e-tests/tests/collection-schema-tab.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import {
66
screenshotIfFailed,
77
skipForWeb,
88
DEFAULT_CONNECTION_NAME_1,
9+
TEST_COMPASS_WEB,
910
} from '../helpers/compass';
1011
import type { Compass } from '../helpers/compass';
1112
import * as Selectors from '../helpers/selectors';
@@ -116,9 +117,8 @@ describe('Collection schema tab', function () {
116117

117118
describe('with the enableExportSchema feature flag enabled', function () {
118119
beforeEach(async function () {
119-
// TODO(COMPASS-8819): remove web skip when defaulted true.
120-
skipForWeb(this, "can't toggle features in compass-web");
121-
await browser.setFeature('enableExportSchema', true);
120+
if (!TEST_COMPASS_WEB)
121+
await browser.setFeature('enableExportSchema', true);
122122
});
123123

124124
const filename = 'schema-test-numbers-mongoDBJSON.json';

packages/compass-schema/src/stores/schema-export-reducer.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -176,6 +176,9 @@ export const downloadSchema = (): SchemaThunkAction<void> => {
176176
link.remove();
177177
}, 0);
178178
dispatch(trackSchemaExported);
179+
return dispatch({
180+
type: SchemaExportActions.closeExportSchema,
181+
});
179182
} catch (error) {
180183
_trackSchemaExportFailed({
181184
stage: 'download button clicked',

0 commit comments

Comments
 (0)