chore(monorepo): Check typescript in test files too (#3273)

Author: gribnoysup

packages/compass-aggregations/package.json

@@ -20,7 +20,7 @@
     "webpack": "webpack-compass",
     "start": "npm run webpack serve -- --mode development",
     "analyze": "npm run webpack -- --mode production --analyze",
-    "typecheck": "tsc --noEmit",
+    "typecheck": "tsc -p tsconfig-lint.json --noEmit",
     "depcheck": "compass-scripts check-peer-deps && depcheck",
     "eslint": "eslint",
     "lint": "npm run eslint .",

packages/compass-aggregations/src/components/pipeline-explain/index.spec.tsx

@@ -16,7 +16,6 @@ const renderPipelineExplain = (
       isModalOpen={true}
       onCancelExplain={() => {}}
       onCloseModal={() => {}}
-      onRunExplain={() => {}}
       {...props}
     />
   );
@@ -33,7 +32,7 @@ describe('PipelineExplain', function () {
     expect(within(modal).getByTestId('pipeline-explain-cancel')).to.exist;
     expect(onCancelExplainSpy.callCount).to.equal(0);
 
-    userEvent.click(within(modal).getByText(/cancel/gi), null, {
+    userEvent.click(within(modal).getByText(/cancel/gi), undefined, {
       skipPointerEventsCheck: true,
     });
     expect(onCancelExplainSpy.callCount).to.equal(1);

packages/compass-aggregations/src/components/pipeline-toolbar/index.spec.tsx

@@ -78,7 +78,7 @@ describe('PipelineToolbar', function () {
       expect(
         within(settings)
           .getByTestId('pipeline-name')
-          .textContent.trim()
+          ?.textContent?.trim()
           .toLowerCase(),
         'shows untitled as default name'
       ).to.equal('untitled');

packages/compass-aggregations/src/components/pipeline-toolbar/pipeline-header/pipeline-actions.spec.tsx

@@ -68,7 +68,7 @@ describe('PipelineActions', function () {
     it('calls onToggleOptions on click', function () {
       const button = screen.getByTestId('pipeline-toolbar-options-button');
       expect(button).to.exist;
-      expect(button.textContent.toLowerCase().trim()).to.equal('less options');
+      expect(button?.textContent?.toLowerCase().trim()).to.equal('less options');
       expect(within(button).getByLabelText('Caret Down Icon')).to.exist;
 
       userEvent.click(button);
@@ -101,7 +101,7 @@ describe('PipelineActions', function () {
     it('toggle options action button', function () {
       const button = screen.getByTestId('pipeline-toolbar-options-button');
       expect(button).to.exist;
-      expect(button.textContent.toLowerCase().trim()).to.equal('more options');
+      expect(button?.textContent?.toLowerCase().trim()).to.equal('more options');
       expect(within(button).getByLabelText('Caret Right Icon')).to.exist;
 
       userEvent.click(button);

packages/compass-aggregations/src/components/pipeline-toolbar/pipeline-settings/pipeline-name.spec.tsx

@@ -7,7 +7,7 @@ import { PipelineName } from './pipeline-name';
 describe('PipelineName', function () {
   it('renders Untitled as default name', function () {
     render(<PipelineName name={''} isModified={false} />);
-    expect(screen.getByTestId('pipeline-name').textContent.trim()).to.equal(
+    expect(screen.getByTestId('pipeline-name')?.textContent?.trim()).to.equal(
       'Untitled'
     );
   });
@@ -17,14 +17,14 @@ describe('PipelineName', function () {
     expect(
       screen
         .getByTestId('pipeline-name')
-        .textContent.trim()
+        ?.textContent?.trim()
         .replace(/\u00a0/g, ' ')
     ).to.equal('Untitled – modified');
   });
 
   it('renders pipeline name', function () {
     render(<PipelineName name={'Hello'} isModified={false} />);
-    expect(screen.getByTestId('pipeline-name').textContent.trim()).to.equal(
+    expect(screen.getByTestId('pipeline-name')?.textContent?.trim()).to.equal(
       'Hello'
     );
   });
@@ -34,7 +34,7 @@ describe('PipelineName', function () {
     expect(
       screen
         .getByTestId('pipeline-name')
-        .textContent.trim()
+        ?.textContent?.trim()
         .replace(/\u00a0/g, ' ')
     ).to.equal('Name changed – modified');
   });

packages/compass-aggregations/src/modules/auto-preview.spec.ts

@@ -30,7 +30,7 @@ describe('auto preview module', function () {
       close: spy(),
     };
     const dataServiceMock = new class {
-      aggregate(...args) {
+      aggregate(...args: any[]) {
         const callback = args[args.length - 1];
         callback(null, cursorMock);
       }

packages/compass-aggregations/src/modules/explain.spec.ts

@@ -13,6 +13,7 @@ import reducer, {
 } from './explain';
 import configureStore from '../stores/store';
 import { DATA_SERVICE_CONNECTED } from './data-service';
+import type { IndexInfo } from './indexes';
 
 describe('explain module', function () {
   describe('#reducer', function () {
@@ -130,9 +131,9 @@ describe('explain module', function () {
     });
 
     it('maps indexes correctly', function () {
-      const collectionIndexes = [
-        { ns: 'test.users', name: '_id_', key: { _id: 1 } },
-        { ns: 'test.users', name: '_location_', key: { _address: '2dsphere' } }
+      const collectionIndexes: IndexInfo[] = [
+        { ns: 'test.users', name: '_id_', key: { _id: 1 }, extra: {} },
+        { ns: 'test.users', name: '_location_', key: { _address: '2dsphere' }, extra: {} }
       ];
       const explainIndexes = [
         { index: '_id_', shard: 'shard01' },

packages/compass-aggregations/src/modules/explain.ts

@@ -1,4 +1,4 @@
-import type { Reducer } from 'redux';
+import type { AnyAction, Reducer } from 'redux';
 import type { AggregateOptions, Document } from 'mongodb';
 import type { ExplainExecuteOptions } from 'mongodb-data-service';
 import type { ThunkAction } from 'redux-thunk';
@@ -74,7 +74,7 @@ export const INITIAL_STATE: State = {
   isModalOpen: false,
 };
 
-const reducer: Reducer<State, Actions> = (state = INITIAL_STATE, action) => {
+const reducer: Reducer<State, AnyAction> = (state = INITIAL_STATE, action) => {
   switch (action.type) {
     case ActionTypes.ExplainStarted:
       return {

packages/compass-aggregations/src/modules/index.ts

@@ -1,5 +1,5 @@
 import { combineReducers } from 'redux';
-import type { AnyAction } from 'redux';
+import type { AnyAction , Reducer } from 'redux';
 import type { ThunkAction } from 'redux-thunk';
 import { ObjectId } from 'bson';
 import isEmpty from 'lodash.isempty';
@@ -577,14 +577,14 @@ const MAPPINGS = {
 /**
  * The root reducer.
  *
- * @param {Object} state - The state.
- * @param {Object} action - The action.
+ * @param state - The state.
+ * @param action - The action.
  *
- * @returns {Object} The new state.
+ * @returns The new state.
  */
-const rootReducer = (state: RootState, action: AnyAction): RootState => {
+const rootReducer: Reducer<RootState, AnyAction> = (state, action): RootState => {
   const fn = MAPPINGS[action.type];
-  return fn ? fn(state, action) : appReducer(state, action);
+  return (state && fn) ? fn(state, action) : appReducer(state, action);
 };
 
 export default rootReducer;

packages/compass-collection/package.json

@@ -52,7 +52,7 @@
     "test-watch": "npm run test -- --watch",
     "test-ci": "npm run test-cov",
     "test-ci-electron": "npm run test-electron",
-    "typecheck": "tsc --noEmit",
+    "typecheck": "tsc -p tsconfig-lint.json --noEmit",
     "reformat": "npm run prettier -- --write ."
   },
   "peerDependencies": {