👕 back to a base state of 0 errors

imlucas · imlucas · commit a5335e289a12 · 2015-10-30T14:10:40.000-04:00
cc @rueckstiess
diff --git a/.eslintrc b/.eslintrc
@@ -1,6 +1,9 @@
 {
-  "env": {
-    "mocha": true
-  },
-  "extends": "mongodb-js/node"
+  "extends": [
+    "mongodb-js/node",
+    "mongodb-js/browser"
+  ],
+  "rules": {
+    "camelcase": 1
+  }
 }
diff --git a/package.json b/package.json
@@ -57,8 +57,8 @@
     "release": "gulp release",
     "test": "mocha",
     "ci": "npm run check && npm run release",
-    "check": "mongodb-js-precommit",
-    "fmt": "mongodb-js-fmt src/{**/*.js,*.js}"
+    "check": "mongodb-js-precommit ./*.js src/{**/*.js,*.js} test/{**/*.js,*.js} tasks/*.js",
+    "fmt": "mongodb-js-fmt ./*.js src/{**/*.js,*.js} test/{**/*.js,*.js} tasks/*.js"
   },
   "pre-commit": [
     "check"
diff --git a/src/.eslintrc b/src/.eslintrc
diff --git a/src/connect/index.js b/src/connect/index.js
@@ -344,8 +344,8 @@ var ConnectView = View.extend({
       // `Untitled (\d)` connections, increment a counter
       // on them like every MS Office does.
       var untitleds = _.chain(this.connections.models)
-        .filter(function(model) {
-          return _.startsWith(model.name, 'Untitled (');
+        .filter(function(m) {
+          return _.startsWith(m.name, 'Untitled (');
         })
         .sort('name')
         .value();
diff --git a/src/electron/menu.js b/src/electron/menu.js
@@ -1,19 +1,6 @@
 var app = require('app');
 var Menu = require('menu');
 
-var menu = (function() {
-  return {
-    init: function(window) {
-      /* eslint-disable no-extra-parens */
-      var menu = (process.platform == 'darwin')
-        ? darwinMenu(window) : nonDarwinMenu(window);
-      /* eslint-enable no-extra-parens */
-      menu = Menu.buildFromTemplate(menu);
-      Menu.setApplicationMenu(menu);
-    }
-  };
-}());
-
 // menus
 function darwinMenu(window) {
   return [
@@ -158,7 +145,7 @@ function darwinMenu(window) {
       ]
     }
   ];
-};
+}
 
 function nonDarwinMenu(window) {
   return [
@@ -204,6 +191,21 @@ function nonDarwinMenu(window) {
       ]
     }
   ];
-};
+}
+
+var menu = (function() {
+  return {
+    init: function(window) {
+      var m;
+      if (process.platform === 'darwin') {
+        m = darwinMenu(window);
+      } else {
+        m = nonDarwinMenu(window);
+      }
+      m = Menu.buildFromTemplate(m);
+      Menu.setApplicationMenu(m);
+    }
+  };
+}());
 
-module.exports = menu;
+module.exports = menu;
diff --git a/src/electron/scout-server-ctl.js b/src/electron/scout-server-ctl.js
@@ -12,7 +12,7 @@
 var fs = require('fs');
 var path = require('path');
 var app = require('app');
-var child_process = require('child_process');
+var spawn = require('child_process').spawn;
 var debug = require('debug')('scout:electron:scout-server-ctl');
 
 // Where we'll keep the process id.
@@ -67,8 +67,8 @@ var killIfRunning = function(done) {
     debug('killing existing pid', pid);
     try {
       process.kill(pid, 'SIGTERM');
-    } catch (err) {
-      if (err.code === 'ESRCH') {
+    } catch (e) {
+      if (e.code === 'ESRCH') {
         debug('orphaned pid file');
       }
     }
@@ -92,7 +92,7 @@ module.exports.start = function(done) {
     // not!  `child_process.exec` has space escape issues
     // but not `child_process.spawn`!
     debug('spawning: `%s %s`...', process.execPath, BIN);
-    var server = child_process.spawn(process.execPath, [BIN], {
+    var server = spawn(process.execPath, [BIN], {
       env: {
         ATOM_SHELL_INTERNAL_RUN_AS_NODE: '1',
         RESOURCES_PATH: process.resourcesPath
diff --git a/src/electron/window-manager.js b/src/electron/window-manager.js
@@ -67,17 +67,22 @@ module.exports.create = function(opts) {
   // makes the application a single instance application
   // see "app.makeSingleInstance" in https://github.com/atom/electron/blob/master/docs/api/app.md
   var shouldQuit = app.makeSingleInstance(function(commandLine, workingDirectory) {
-  // Someone tried to run a second instance, we should focus our window
+    debug('Someone tried to run a second instance! We should focus our window', {
+      commandLine: commandLine,
+      workingDirectory: workingDirectory
+    });
     if (_window) {
-      if (_window.isMinimized()) _window.restore();
+      if (_window.isMinimized()) {
+        _window.restore();
+      }
       _window.focus();
     }
     return true;
   });
 
   if (shouldQuit) {
     app.quit();
-    return;
+    return null;
   }
 
   _window.loadUrl(opts.url);
diff --git a/src/minicharts/d3-tip.js b/src/minicharts/d3-tip.js
@@ -1,13 +1,11 @@
+/* eslint no-use-before-define: 1, one-var: 1, no-else-return: 1, no-unused-vars: 1, eqeqeq: 1, no-shadow: 1, yoda: 1, consistent-return: 1, one-var: 1 */
 // d3.tip
 // Copyright (c) 2013 Justin Palmer
 //
 // Tooltips for d3.js SVG visualizations
 
 (function(root, factory) {
-  if (typeof define === 'function' && define.amd) {
-    // AMD. Register as an anonymous module with d3 as a dependency.
-    define(['d3'], factory);
-  } else if (typeof module === 'object' && module.exports) {
+  if (typeof module === 'object' && module.exports) {
     // CommonJS
     module.exports = function(d3) {
       d3.tip = factory(d3);
@@ -18,18 +16,17 @@
     root.d3.tip = factory(root.d3);
   }
 }(this, function(d3) {
-
   // Public - contructs a new tooltip
   //
   // Returns a tip
   return function() {
-    var direction = d3_tip_direction,
-      offset = d3_tip_offset,
-      html = d3_tip_html,
-      node = initNode(),
-      svg = null,
-      point = null,
-      target = null;
+    var direction = d3_tip_direction;
+    var offset = d3_tip_offset;
+    var html = d3_tip_html;
+    var node = initNode();
+    var svg = null;
+    var point = null;
+    var target = null;
 
     function tip(vis) {
       svg = getSVGNode(vis);
@@ -349,5 +346,4 @@
 
     return tip;
   };
-
 }));
diff --git a/src/minicharts/d3fns/date.js b/src/minicharts/d3fns/date.js
@@ -1,3 +1,4 @@
+/* eslint no-use-before-define:1 */
 var d3 = require('d3');
 var _ = require('lodash');
 var $ = require('jquery');
@@ -309,7 +310,7 @@ var minicharts_d3fns_date = function() {
 
       raf(function() {
         var chartWidth = width / (upperRatio + 1) - upperMargin;
-        var chart = many()
+        var manyChart = many()
           .width(chartWidth)
           .height(upperBarBottom)
           .options({
@@ -323,13 +324,13 @@ var minicharts_d3fns_date = function() {
             },
             view: options.view
           });
-        weekdayContainer.call(chart);
+        weekdayContainer.call(manyChart);
       });
 
       var hourContainer = g.select('g.hour').data([hours]);
       raf(function() {
         var chartWidth = width / (upperRatio + 1) * upperRatio - upperMargin;
-        var chart = many()
+        var manyChart = many()
           .width(chartWidth)
           .height(upperBarBottom)
           .options({
@@ -342,7 +343,7 @@ var minicharts_d3fns_date = function() {
             },
             view: options.view
           });
-        hourContainer.call(chart);
+        hourContainer.call(manyChart);
       });
     });
   }
diff --git a/src/minicharts/d3fns/few.js b/src/minicharts/d3fns/few.js
@@ -1,3 +1,4 @@
+/* eslint no-use-before-define:1 */
 var d3 = require('d3');
 var _ = require('lodash');
 var $ = require('jquery');
diff --git a/src/minicharts/d3fns/many.js b/src/minicharts/d3fns/many.js
@@ -1,3 +1,4 @@
+/* eslint no-use-before-define:1 */
 var d3 = require('d3');
 var $ = require('jquery');
 var _ = require('lodash');
diff --git a/src/minicharts/d3fns/number.js b/src/minicharts/d3fns/number.js
@@ -16,13 +16,14 @@ var minicharts_d3fns_number = function() {
 
   function chart(selection) {
     selection.each(function(data) {
+      var grouped;
       var el = d3.select(this);
       var innerWidth = width - margin.left - margin.right;
       var innerHeight = height - margin.top - margin.bottom;
 
       // transform data
       if (options.model.unique < 20) {
-        var grouped = _(data)
+        grouped = _(data)
           .groupBy(function(d) {
             return d;
           })
diff --git a/src/minicharts/querybuilder.js b/src/minicharts/querybuilder.js
@@ -312,6 +312,7 @@ module.exports = {
       _.each(message.elements, function(el) {
         var d = getOrderedValueHelper(d3.select(el).data()[0]);
         var mustSelect = false;
+        var halfSelect;
         if (message.selected.length === 1) {
           // handle single selection of non-binned data
           mustSelect = d.value === message.selected[0];
@@ -321,7 +322,7 @@ module.exports = {
             && checkBounds[message.upperOp](d.value, message.selected[1]);
         } else {
           // handle binned ranges
-          var halfSelect = false;
+          halfSelect = false;
           /**
            * 4 cases to consider: upper/lower bound  x  hit bound exactly/not
            */
diff --git a/src/minicharts/viz.js b/src/minicharts/viz.js
@@ -1,4 +1,4 @@
-/* eslint indent:0 */
+/* eslint indent:0, complexity:0 */
 var AmpersandView = require('ampersand-view');
 var _ = require('lodash');
 var $ = require('jquery');
diff --git a/src/models/connection.js b/src/models/connection.js
@@ -24,31 +24,32 @@ module.exports = Connection.extend({
     last_used: 'date'
   },
   test: function(done) {
-    var model = this;
-    debug('Testing connection to `%j`...', this);
-    client.test(app.endpoint, model.serialize({
-      all: true
-    }), function(err) {
+    var model = this.serialize();
+
+    var onInstanceFetched = function(err, res) {
+      if (!err) {
+        debug('woot.  all gravy!  able to see %s collections', res.collections.length);
+        done(null, this);
+        return;
+      }
+      debug('could not get collection list :( sending to bugsnag for follow up...');
+      bugsnag.notify(err, 'collection list failed');
+      done(err);
+    }.bind(this);
+
+    var onTested = function(err) {
       if (err) {
         bugsnag.notify(err, 'connection test failed');
         return done(err);
       }
 
       debug('test worked!');
       debug('making sure we can get collection list...');
-      client(app.endpoint, model.serialize({
-        all: true
-      })).instance(function(err, res) {
-        if (!err) {
-          debug('woot.  all gravy!  able to see %s collections', res.collections.length);
-          done(null, model);
-          return;
-        }
-        debug('could not get collection list :( sending to bugsnag for follow up...');
-        bugsnag.notify(err, 'collection list failed');
-        done(err);
-      });
-    });
+      client(app.endpoint, model).instance(onInstanceFetched);
+    };
+
+    debug('Testing connection to `%j`...', model);
+    client.test(app.endpoint, model, onTested);
     return this;
   },
   sync: connectionSync,
diff --git a/src/models/sampled-schema.js b/src/models/sampled-schema.js
@@ -177,9 +177,9 @@ module.exports = Schema.extend({
         'Errored Document Count': erroredOnDocs.length,
         'Time to First Doc': timeToFirstDoc,
         'Average Time Per Doc': (totalTime - timeToFirstDoc) / model.documents.length
-        // 'Schema Height': model.height, // # of top level keys
-        // 'Schema Width': model.width, // max nesting depth
-        // 'Schema Sparsity': model.sparsity // lots of fields missing or consistent
+      // 'Schema Height': model.height, // # of top level keys
+      // 'Schema Width': model.width, // max nesting depth
+      // 'Schema Sparsity': model.sparsity // lots of fields missing or consistent
       });
       options.success({});
     };
diff --git a/src/sampling-message/index.js b/src/sampling-message/index.js
@@ -1,9 +1,7 @@
 var View = require('ampersand-view');
 var pluralize = require('pluralize');
-var format = require('util').format;
 var app = require('ampersand-app');
 var numeral = require('numeral');
-var debug = require('debug')('scout:sampling-message:index');
 
 var SamplingMessageView = View.extend({
   template: require('./index.jade'),
@@ -33,7 +31,7 @@ var SamplingMessageView = View.extend({
         if (this.total_count === 0) {
           return '0%';
         }
-        return numeral(this.sample_size / this.total_count).format('0.00%')
+        return numeral(this.sample_size / this.total_count).format('0.00%');
       }
     },
     is_sample: {
diff --git a/src/sidebar/collection-list-item.js b/src/sidebar/collection-list-item.js
@@ -10,7 +10,7 @@ var CollectionListItemView = View.extend({
     title: {
       type: 'attribute',
       hook: 'ns',
-      name: 'title',
+      name: 'title'
     },
     'model.selected': {
       type: 'booleanClass',
diff --git a/src/tour/index.js b/src/tour/index.js
diff --git a/tasks/darwin.js b/tasks/darwin.js
diff --git a/tasks/run.js b/tasks/run.js
diff --git a/tasks/win32.js b/tasks/win32.js
diff --git a/tasks/windows-max-path-length-check.js b/tasks/windows-max-path-length-check.js

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,9 @@`
`1`	`1`	`{`
`2`		`- "env": {`
`3`		`- "mocha": true`
`4`		`- },`
`5`		`- "extends": "mongodb-js/node"`
	`2`	`+ "extends": [`
	`3`	`+ "mongodb-js/node",`
	`4`	`+ "mongodb-js/browser"`
	`5`	`+ ],`
	`6`	`+ "rules": {`
	`7`	`+ "camelcase": 1`
	`8`	`+ }`
`6`	`9`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+/* eslint no-use-before-define:1 */`
`1`	`2`	`var d3 = require('d3');`
`2`	`3`	`var _ = require('lodash');`
`3`	`4`	`var $ = require('jquery');`