chore(ci): use Node.js 20 in CI (#6100)

addaleax · web-flow · commit a7daa717fbf4 · 2024-08-09T16:01:39.000+02:00
* chore(ci): use Node.js 20 in CI

* fixup: bump Node.js in Dockerfile

* fixup: use CustomEvent and EventTarget from window

* fixup! fixup: use CustomEvent and EventTarget from window

* fixup: use shell for spawning batch scripts, remove extra `which` indirection

* fixup: bump kerberos to latest

* fixup: check

* fixup: skip kerberos rtld for macos

* fixup: refactor hadron-build run error messaging

* fixup: move EventTarget and friends to jsdom-extra-mocks-register

* fixup: docker file version management suggestion

* fixup: mention new minimum version in CONTRIBUTING.md
diff --git a/.evergreen/connectivity-tests/Dockerfile b/.evergreen/connectivity-tests/Dockerfile
@@ -1,5 +1,6 @@
 # "bullseye" is the debian distribution that ubuntu:20.04 is based on
-FROM node:18-bullseye
+ARG NODE_JS_VERSION=20
+FROM node:${NODE_JS_VERSION}-bullseye
 
 COPY .evergreen/connectivity-tests/krb5.conf /etc/krb5.conf
 
diff --git a/.evergreen/connectivity-tests/run.sh b/.evergreen/connectivity-tests/run.sh
@@ -7,7 +7,7 @@ MONOREPO_ROOT_DIR="$(cd $(dirname "$0")/../..; pwd)"
 cd $MONOREPO_ROOT_DIR
 
 echo "building connectivity tests image from ${PWD}"
-docker build -t devtools-connectivity-tests -f "./.evergreen/connectivity-tests/Dockerfile" .
+docker build -t devtools-connectivity-tests --build-arg "NODE_JS_VERSION=$NODE_JS_VERSION" -f "./.evergreen/connectivity-tests/Dockerfile" .
 echo "connectivity tests image built"
 
 echo running connectivity tests image
diff --git a/.evergreen/functions.yml b/.evergreen/functions.yml
@@ -40,11 +40,7 @@ variables:
     EVERGREEN_VERSION_ID: ${version_id}
     EVERGREEN_WORKDIR: ${workdir}
     EVERGREEN_CREATED_AT: ${created_at}
-    # WARN: This version is behind our electron runtime, but updating it will
-    # drop support for some older linux platforms, so we are keeping them out of
-    # sync for now
-    # TODO: https://jira.mongodb.org/browse/COMPASS-6915
-    NODE_JS_VERSION: '18.19.1'
+    NODE_JS_VERSION: '20.16.0'
     NPM_VERSION: '10.2.4'
     # secrets
     HADRON_METRICS_INTERCOM_APP_ID: ${metrics_intercom_app_id}
diff --git a/.evergreen/print-compass-env.js b/.evergreen/print-compass-env.js
@@ -107,6 +107,13 @@ function printCompassEnv() {
   printVar('DEV_VERSION_IDENTIFIER', process.env.DEV_VERSION_IDENTIFIER);
   printVar('EVERGREEN_REVISION', process.env.EVERGREEN_REVISION);
   printVar('EVERGREEN_REVISION_ORDER_ID', process.env.EVERGREEN_REVISION_ORDER_ID);
+
+  if (process.platform === 'darwin') {
+    // Without this, kerberos 2.1.1 is broken on macOS, but this flag is only
+    // really relevant for Linux.
+    // https://jira.mongodb.org/browse/NODE-6320
+    printVar('GYP_DEFINES', 'kerberos_use_rtld=false');
+  }
 }
 
 printCompassEnv();
diff --git a/.github/workflows/authors-and-third-party-notices.yaml b/.github/workflows/authors-and-third-party-notices.yaml
@@ -25,7 +25,7 @@ jobs:
 
       - uses: actions/setup-node@v3
         with:
-          node-version: 18.19.1
+          node-version: 20.16.0
           cache: 'npm'
 
       - name: Install npm@10.2.4
diff --git a/.github/workflows/bump-packages.yaml b/.github/workflows/bump-packages.yaml
@@ -26,7 +26,7 @@ jobs:
 
       - uses: actions/setup-node@v3
         with:
-          node-version: 18.19.1
+          node-version: 20.16.0
           cache: 'npm'
 
       - name: Install npm@10.2.4
diff --git a/.github/workflows/publish-compass.yaml b/.github/workflows/publish-compass.yaml
@@ -22,7 +22,7 @@ jobs:
       - name: Setup Node.js Environment
         uses: actions/setup-node@v3
         with:
-          node-version: 18.19.1
+          node-version: 20.16.0
           cache: 'npm'
 
       - name: Install npm@10.2.4
diff --git a/.github/workflows/publish-packages.yaml b/.github/workflows/publish-packages.yaml
@@ -34,7 +34,7 @@ jobs:
     - name: "Use Node.js 14"
       uses: actions/setup-node@v3
       with:
-        node-version: 18.19.1
+        node-version: 20.16.0
 
     - name: Install npm@10.2.4
       run: npm install -g npm@10.2.4
diff --git a/.github/workflows/start-beta.yml b/.github/workflows/start-beta.yml
@@ -29,7 +29,7 @@ jobs:
 
       - uses: actions/setup-node@v3
         with:
-          node-version: 18.19.1
+          node-version: 20.16.0
           cache: 'npm'
 
       - name: Install npm@10.2.4
diff --git a/.github/workflows/start-ga.yaml b/.github/workflows/start-ga.yaml
@@ -29,7 +29,7 @@ jobs:
 
       - uses: actions/setup-node@v3
         with:
-          node-version: 18.19.1
+          node-version: 20.16.0
           cache: 'npm'
 
       - name: Install npm@10.2.4
diff --git a/.github/workflows/update-electron.yaml b/.github/workflows/update-electron.yaml
@@ -26,7 +26,7 @@ jobs:
           git config --local user.name "github-actions[bot]"
       - uses: actions/setup-node@v3
         with:
-          node-version: 18.19.1
+          node-version: 20.16.0
           cache: 'npm'
 
       - name: Install npm@10.2.4
@@ -50,4 +50,4 @@ jobs:
           branch: ci/update-electron
           title: 'chore: update electron'
           body: |
-            - Update electron
+            - Update electron
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -3,7 +3,7 @@
 
 ## Getting Started
 
-You'll need node `^18` and npm `^10` installed on your machine to work with the repository locally.
+You'll need node `^20` and npm `^10` installed on your machine to work with the repository locally.
 After your environment is ready, navigate to the repository and run `npm run bootstrap`, this will install dependencies and will compile all packages.
 
 After bootstrap is finished, you should be able to run `npm run start` and see Compass application running locally. Alternatively you can start a web version of the app by running `npm run start-web`.
diff --git a/configs/mocha-config-compass/register/jsdom-extra-mocks-register.js b/configs/mocha-config-compass/register/jsdom-extra-mocks-register.js
@@ -43,3 +43,9 @@ if (!window.document.queryCommandSupported) {
       return ['copy', 'cut'].includes(command);
     };
 }
+
+// COMPASS-7357: jsdom `EventTarget` doesn't play nicely with Node.js `CustomEvent` yet,
+// so always pick the `window`/jsdom-based variant
+globalThis.EventTarget = window.EventTarget;
+globalThis.CustomEvent = window.CustomEvent;
+globalThis.Event = window.Event;
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -79,7 +79,7 @@
     "node-gyp": "^8.4.1"
   },
   "engines": {
-    "node": ">=18.19.1",
+    "node": ">=20.15.0",
     "npm": ">=10.2.4"
   },
   "bugs": {
diff --git a/packages/compass-components/src/components/guide-cue/guide-cue-service.ts b/packages/compass-components/src/components/guide-cue/guide-cue-service.ts
@@ -88,19 +88,14 @@ export class GuideCueService extends EventTarget {
     if (!this._activeCue) {
       return;
     }
-    try {
-      return this.dispatchEvent(
-        new CustomEvent('show-cue', {
-          detail: {
-            cueId: this._activeCue.cueId,
-            groupId: this._activeCue.groupId,
-          },
-        })
-      );
-    } catch (ex) {
-      // TODO(COMPASS-7357): this seems to be a temporary error happening sometimes during test.
-      // In that case, assume the event is not dispatched
-    }
+    return this.dispatchEvent(
+      new CustomEvent('show-cue', {
+        detail: {
+          cueId: this._activeCue.cueId,
+          groupId: this._activeCue.groupId,
+        },
+      })
+    );
   }
 
   private validateCueData(groupId: GroupName, step: number) {
diff --git a/packages/compass/package.json b/packages/compass/package.json
@@ -183,7 +183,7 @@
   "dependencies": {
     "@mongosh/node-runtime-worker-thread": "^2.2.15",
     "clipboard": "^2.0.6",
-    "kerberos": "^2.1.0",
+    "kerberos": "^2.1.1",
     "keytar": "^7.9.0",
     "mongodb-client-encryption": "^6.0.0",
     "os-dns-native": "^1.2.1",
diff --git a/packages/data-service/package.json b/packages/data-service/package.json
@@ -76,7 +76,7 @@
     "chai-as-promised": "^7.1.1",
     "depcheck": "^1.4.1",
     "eslint": "^7.25.0",
-    "kerberos": "^2.1.0",
+    "kerberos": "^2.1.1",
     "mocha": "^10.2.0",
     "nyc": "^15.1.0",
     "prettier": "^2.7.1",
diff --git a/packages/hadron-build/commands/release.js b/packages/hadron-build/commands/release.js
@@ -344,7 +344,8 @@ const installDependencies = util.callbackify(async(CONFIG) => {
   cli.debug('Installing dependencies and rebuilding native modules');
 
   const opts = {
-    cwd: appPackagePath
+    cwd: appPackagePath,
+    shell: true
   };
 
   await run.async('npm', ['install', '--production'], opts);
diff --git a/packages/hadron-build/commands/verify.js b/packages/hadron-build/commands/verify.js
@@ -38,7 +38,7 @@ exports.checkNpmAndNodejsVersions = async(opts) => {
   const expectNodeVersion = opts.nodejs_version;
   const expectNpmVersion = opts.npm_version;
   const args = ['version', '--json', '--loglevel', 'error'];
-  const stdout = await runAsync('npm', args, {env: process.env});
+  const stdout = await runAsync('npm', args, {env: process.env, shell: true});
   const versions = JSON.parse(stdout);
 
   if (!semver.satisfies(versions.node, expectNodeVersion)) {
diff --git a/packages/hadron-build/lib/run.js b/packages/hadron-build/lib/run.js
