make isSearchPipelineQueryable true for not read only views

Author: DarshanaVenkatesh

packages/compass-indexes/src/components/indexes-toolbar/indexes-toolbar.tsx

@@ -33,6 +33,7 @@ import type { IndexView } from '../../modules/index-view';
 import { indexViewChanged } from '../../modules/index-view';
 import type { CollectionStats } from '../../modules/collection-stats';
 import { isPipelineSearchQueryable } from '@mongodb-js/compass-utils';
+import type { Document } from 'mongodb';
 
 const toolbarButtonsContainer = css({
   display: 'flex',
@@ -127,10 +128,9 @@ export const IndexesToolbar: React.FunctionComponent<IndexesToolbarProps> = ({
     <Icon glyph="Refresh" title="Refresh Indexes" />
   );
   const isViewPipelineSearchQueryable =
-    (isReadonlyView &&
-      collectionStats?.pipeline &&
-      isPipelineSearchQueryable(collectionStats.pipeline as Document[])) ??
-    true;
+    isReadonlyView && collectionStats?.pipeline
+      ? isPipelineSearchQueryable(collectionStats.pipeline as Document[])
+      : true;
   const pipelineNotSearchQueryableDescription =
     'Search indexes can only be created on  views containing $addFields, $set or $match stages with the $expr operator.';
   return (

packages/compass-indexes/src/components/indexes/indexes.tsx

@@ -39,6 +39,7 @@ import semver from 'semver';
 import type { SearchIndex } from 'mongodb-data-service';
 import type { CollectionStats } from '../../modules/collection-stats';
 import { isPipelineSearchQueryable } from '@mongodb-js/compass-utils';
+import type { Document } from 'mongodb';
 
 // This constant is used as a trigger to show an insight whenever number of
 // indexes in a collection is more than what is specified here.
@@ -232,10 +233,9 @@ export function Indexes({
   const enableAtlasSearchIndexes = usePreference('enableAtlasSearchIndexes');
   const { atlasMetadata } = useConnectionInfo();
   const isViewPipelineSearchQueryable =
-    (isReadonlyView &&
-      collectionStats?.pipeline &&
-      isPipelineSearchQueryable(collectionStats.pipeline as Document[])) ??
-    true;
+    isReadonlyView && collectionStats?.pipeline
+      ? isPipelineSearchQueryable(collectionStats.pipeline as Document[])
+      : true;
 
   const getBanner = () => {
     if (isReadonlyView) {

packages/compass-indexes/src/components/search-indexes-table/search-indexes-table.tsx

@@ -322,12 +322,10 @@ export const SearchIndexesTable: React.FunctionComponent<
     };
   }, [tabId, onSearchIndexesOpened, onSearchIndexesClosed]);
   const isViewPipelineSearchQueryable =
-    (isReadonlyView &&
-      collectionStats?.pipeline &&
-      isPipelineSearchQueryable(
-        collectionStats.pipeline as Array<Record<string, any>>
-      )) ??
-    true;
+    isReadonlyView && collectionStats?.pipeline
+      ? isPipelineSearchQueryable(collectionStats.pipeline as Document[])
+      : true;
+
   const data = useMemo<LGTableDataType<SearchIndexInfo>[]>(
     () =>
       indexes.map((index) => {