PR feedback

Author: paula-stacho

packages/compass-aggregations/src/modules/aggregation.ts

@@ -260,7 +260,6 @@ const confirmWriteOperationIfNeeded = async ({
         dataService,
         database,
         collection,
-        preferences,
       }));
     } else {
       isOverwritingCollection = true;

packages/compass-app-stores/src/stores/instance-store.ts

@@ -108,7 +108,6 @@ export function createInstancesStore(
       await instance.refresh({
         dataService,
         ...refreshOptions,
-        preferences,
       });
     } catch (err: any) {
       log.warn(

packages/compass-preferences-model/src/preferences-schema.tsx

@@ -19,7 +19,7 @@ import { Link } from '@mongodb-js/compass-components';
 export const THEMES_VALUES = ['DARK', 'LIGHT', 'OS_THEME'] as const;
 export type THEMES = typeof THEMES_VALUES[number];
 
-const EnableDbAndCollStatsDescription: React.ReactNode = (
+const enableDbAndCollStatsDescription: React.ReactNode = (
   <>
     The{' '}
     <Link href="https://www.mongodb.com/docs/manual/reference/command/dbStats/#mongodb-dbcommand-dbcmd.dbStats">
@@ -512,7 +512,7 @@ export const storedUserPreferencesProps: Required<{
     description: {
       short: 'Show Database and Collection Statistics',
       long: "The dbStats and collStats command returns storage statistics for a given database or collection. Disabling this setting can help reduce Compass' overhead on your MongoDB deployments.",
-      longReact: EnableDbAndCollStatsDescription,
+      longReact: enableDbAndCollStatsDescription,
     },
     validator: z.boolean().default(true),
     type: 'boolean',

packages/compass-saved-aggregations-queries/src/stores/open-item.ts

@@ -499,7 +499,6 @@ export const openSavedItem =
           dataService,
           database,
           collection,
-          preferences,
         });
 
         if (coll) {

packages/compass-settings/src/components/settings/settings-list.tsx

@@ -17,17 +17,11 @@ import {
   Option,
   FormFieldContainer,
   Badge,
-  palette,
 } from '@mongodb-js/compass-components';
 import { changeFieldValue } from '../../stores/settings';
 import type { RootState } from '../../stores';
 import { connect } from 'react-redux';
 
-const inputDescriptionStyles = css({
-  display: 'block',
-  color: palette.gray.dark1,
-});
-
 type KeysMatching<T, V> = keyof {
   [P in keyof T as T[P] extends V ? P : never]: P;
 };
@@ -88,8 +82,7 @@ function SettingLabel({ name }: { name: SupportedPreferences }) {
           </span>
         )}
       </Label>
-      {long && !longReact && <Description>{long}</Description>}
-      {longReact && <div className={inputDescriptionStyles}>{longReact}</div>}
+      {(longReact || long) && <Description>{longReact ?? long}</Description>}
     </>
   );
 }

packages/compass-workspaces/src/stores/workspaces.ts

@@ -703,7 +703,7 @@ const fetchCollectionInfo = (
   return async (
     dispatch,
     getState,
-    { connections, instancesManager, logger, preferences }
+    { connections, instancesManager, logger }
   ) => {
     const namespaceId = `${workspaceOptions.connectionId}.${workspaceOptions.namespace}`;
     if (getState().collectionInfo[namespaceId]) {
@@ -725,7 +725,6 @@ const fetchCollectionInfo = (
         dataService,
         database,
         collection,
-        preferences,
       });
 
       if (coll) {

packages/databases-collections-list/src/collections.tsx

@@ -10,9 +10,11 @@ import { usePreference } from 'compass-preferences-model/provider';
 const COLLECTION_CARD_WIDTH = spacing[1600] * 4;
 
 const COLLECTION_CARD_HEIGHT = 238;
-const COLLECTION_CARD_WITHOUT_STATS_HEIGHT = COLLECTION_CARD_HEIGHT - 40 - 16;
+const COLLECTION_CARD_WITHOUT_STATS_HEIGHT = COLLECTION_CARD_HEIGHT - 150;
 
 const COLLECTION_CARD_LIST_HEIGHT = 118;
+const COLLECTION_CARD_LIST_WITHOUT_STATS_HEIGHT =
+  COLLECTION_CARD_LIST_HEIGHT - 50;
 
 function collectionPropertyToBadge({
   id,
@@ -95,7 +97,11 @@ const CollectionsList: React.FunctionComponent<{
             ? COLLECTION_CARD_HEIGHT
             : COLLECTION_CARD_WITHOUT_STATS_HEIGHT
         }
-        itemListHeight={COLLECTION_CARD_LIST_HEIGHT}
+        itemListHeight={
+          enableDbAndCollStats
+            ? COLLECTION_CARD_LIST_HEIGHT
+            : COLLECTION_CARD_LIST_WITHOUT_STATS_HEIGHT
+        }
         sortBy={[
           { name: 'name', label: 'Collection Name' },
           { name: 'document_count', label: 'Documents' },

packages/databases-collections-list/src/databases.tsx

@@ -13,7 +13,7 @@ const DATABASE_CARD_HEIGHT = 154;
 const DATABASE_CARD_WITHOUT_STATS_HEIGHT = DATABASE_CARD_HEIGHT - 85;
 
 const DATABASE_CARD_LIST_HEIGHT = 118;
-const DATABASE_CARD_WITHOUT_STATS_LIST_HEIGHT = DATABASE_CARD_LIST_HEIGHT - 40;
+const DATABASE_CARD_LIST_WITHOUT_STATS_HEIGHT = DATABASE_CARD_LIST_HEIGHT - 50;
 
 const DatabasesList: React.FunctionComponent<{
   databases: DatabaseProps[];
@@ -44,7 +44,7 @@ const DatabasesList: React.FunctionComponent<{
       itemListHeight={
         enableDbAndCollStats
           ? DATABASE_CARD_LIST_HEIGHT
-          : DATABASE_CARD_WITHOUT_STATS_LIST_HEIGHT
+          : DATABASE_CARD_LIST_WITHOUT_STATS_HEIGHT
       }
       sortBy={[
         { name: 'name', label: 'Database Name' },

packages/instance-model/index.d.ts

@@ -118,7 +118,6 @@ declare class MongoDBInstance extends MongoDBInstanceProps {
   }): Promise<void>;
   refresh(opts: {
     dataService: DataService;
-    preferences: PreferencesAccess;
     fetchDatabases?: boolean;
     fetchDbStats?: boolean;
     fetchCollections?: boolean;
@@ -127,7 +126,6 @@ declare class MongoDBInstance extends MongoDBInstanceProps {
   }): Promise<void>;
   getNamespace(opts: {
     dataService: Pick<DataService, 'instance' | 'getCurrentTopologyType'>;
-    preferences: PreferencesAccess;
     database: string;
     collection: string;
   }): Promise<Collection | null>;