chore: run linting in compass package (#3049)

Author: addaleax

packages/compass/package.json

@@ -141,7 +141,7 @@
     "evergreen-expansions": "hadron-build info --format=yaml --flatten > expansions.yml",
     "build-info": "hadron-build info",
     "jsx": "babel ./src --out-dir ./lib",
-    "lint": "eslint",
+    "lint": "eslint .",
     "depcheck": "depcheck",
     "test-ci": "npm run test-release-tasks",
     "test-ci-electron": "npm run test-electron",

packages/compass/release/branch.spec.js

@@ -9,7 +9,7 @@ const {
   lt
 } = require('./branch');
 
-describe('branches', () => {
+describe('branches', function() {
   if (!!process.env.EVERGREEN && process.platform === 'darwin') {
     // These tests are not working well on Evergreen macOS machines and we will
     // skip them for now (they will run in GitHub CI)
@@ -18,17 +18,17 @@ describe('branches', () => {
     return;
   }
 
-  describe('isMainBranch', () => {
-    it('returns true only if branch is main', () => {
+  describe('isMainBranch', function() {
+    it('returns true only if branch is main', function() {
       expect(isMainBranch('main')).to.be.true;
       expect(isMainBranch('beta')).to.be.false;
       expect(isMainBranch('release/1.2.33')).to.be.false;
       expect(isMainBranch('1.22-releases')).to.be.false;
     });
   });
 
-  describe('isReleaseBranch', () => {
-    it('returns true only for a release branch', () => {
+  describe('isReleaseBranch', function() {
+    it('returns true only for a release branch', function() {
       expect(isReleaseBranch('main')).to.be.false;
       expect(isReleaseBranch('beta')).to.be.false;
       expect(isReleaseBranch('release/1.2.33')).to.be.false;
@@ -37,40 +37,40 @@ describe('branches', () => {
     });
   });
 
-  describe('buildReleaseBranchName', () => {
-    it('returns a release branch name from version', () => {
+  describe('buildReleaseBranchName', function() {
+    it('returns a release branch name from version', function() {
       expect(buildReleaseBranchName('1.2')).to.equal('1.2-releases');
     });
   });
 
-  describe('getFirstBeta', () => {
-    it('throws if not release branch', () => {
+  describe('getFirstBeta', function() {
+    it('throws if not release branch', function() {
       expect(() => {
         getFirstBeta('somebranch');
       }).to.throw('not a release branch');
     });
 
-    it('returns the first beta for a release branch', () => {
+    it('returns the first beta for a release branch', function() {
       expect(getFirstBeta('1.22-releases')).to.equal('1.22.0-beta.0');
       expect(getFirstBeta('1.2-releases')).to.equal('1.2.0-beta.0');
     });
   });
 
-  describe('getFirstGa', () => {
-    it('throws if not release branch', () => {
+  describe('getFirstGa', function() {
+    it('throws if not release branch', function() {
       expect(() => {
         getFirstGa('somebranch');
       }).to.throw('not a release branch');
     });
 
-    it('returns the first beta for a release branch', () => {
+    it('returns the first beta for a release branch', function() {
       expect(getFirstGa('1.22-releases')).to.equal('1.22.0');
       expect(getFirstGa('1.2-releases')).to.equal('1.2.0');
     });
   });
 
-  describe('hasVersion', () => {
-    it('returns true if matching', () => {
+  describe('hasVersion', function() {
+    it('returns true if matching', function() {
       expect(
         hasVersion('1.22-releases', '1.22.0')
       ).to.be.true;
@@ -84,7 +84,7 @@ describe('branches', () => {
       ).to.be.true;
     });
 
-    it('returns false if not matching', () => {
+    it('returns false if not matching', function() {
       expect(
         hasVersion('1.22-releases', '1.21.0')
       ).to.be.false;
@@ -103,8 +103,8 @@ describe('branches', () => {
     });
   });
 
-  describe('lt', () => {
-    it('returns true only if branch is lower than version', () => {
+  describe('lt', function() {
+    it('returns true only if branch is lower than version', function() {
       expect(lt('1.22-releases', '1.23.0')).to.be.true;
       expect(lt('1.22-releases', '2.0.0')).to.be.true;
       expect(lt('1.22-releases', '2.22.0')).to.be.true;

packages/compass/release/bump.spec.js

@@ -4,7 +4,7 @@ const {
   newGa
 } = require('./bump');
 
-describe('bump', () => {
+describe('bump', function() {
   if (!!process.env.EVERGREEN && process.platform === 'darwin') {
     // These tests are not working well on Evergreen macOS machines and we will
     // skip them for now (they will run in GitHub CI)
@@ -13,30 +13,30 @@ describe('bump', () => {
     return;
   }
 
-  describe('newBeta', () => {
-    it('returns new beta for a newly promoted release branch', () => {
+  describe('newBeta', function() {
+    it('returns new beta for a newly promoted release branch', function() {
       expect(newBeta('1.21.0', '1.22-releases')).to.equal('1.22.0-beta.0');
     });
 
-    it('bumps beta for a previous beta', () => {
+    it('bumps beta for a previous beta', function() {
       expect(newBeta('1.22.0-beta.0', '1.22-releases')).to.equal('1.22.0-beta.1');
     });
 
-    it('bumps beta for a previous ga', () => {
+    it('bumps beta for a previous ga', function() {
       expect(newBeta('1.22.0', '1.22-releases')).to.equal('1.22.1-beta.0');
     });
   });
 
-  describe('newGa', () => {
-    it('returns new ga version for a newly promoted release branch', () => {
+  describe('newGa', function() {
+    it('returns new ga version for a newly promoted release branch', function() {
       expect(newGa('1.21.0', '1.22-releases')).to.equal('1.22.0');
     });
 
-    it('bumps beta to new ga', () => {
+    it('bumps beta to new ga', function() {
       expect(newGa('1.22.0-beta.0', '1.22-releases')).to.equal('1.22.0');
     });
 
-    it('bumps ga to a new ga', () => {
+    it('bumps ga to a new ga', function() {
       expect(newGa('1.22.0', '1.22-releases')).to.equal('1.22.1');
     });
   });

packages/compass/release/download-center.spec.js

@@ -7,7 +7,7 @@ const CompassDownloadCenter = require('./download-center');
 chai.use(sinonChai);
 const { expect } = chai;
 
-describe('CompassDownloadCenter', () => {
+describe('CompassDownloadCenter', function() {
   if (!!process.env.EVERGREEN && process.platform === 'darwin') {
     // These tests are not working well on Evergreen macOS machines and we will
     // skip them for now (they will run in GitHub CI)
@@ -18,27 +18,27 @@ describe('CompassDownloadCenter', () => {
 
   let downloadCenter;
   let config;
-  beforeEach(async() => {
+  beforeEach(async function() {
     downloadCenter = new CompassDownloadCenter({});
     config = await fs.readJSON(
       path.resolve(__dirname, 'fixtures', 'config.json')
     );
   });
 
-  describe('getVersion', async() => {
-    it('gets ga version', () => {
+  describe('getVersion', function() {
+    it('gets ga version', function() {
       const gaVersion = downloadCenter.getVersion(config, 'ga');
       expect(gaVersion).to.equal('1.22.1');
     });
 
-    it('gets beta version', () => {
+    it('gets beta version', function() {
       const betaVersion = downloadCenter.getVersion(config, 'beta');
       expect(betaVersion).to.equal('1.23.0-beta.4');
     });
   });
 
-  describe('getAssets', () => {
-    it('returns all the assets for ga', () => {
+  describe('getAssets', function() {
+    it('returns all the assets for ga', function() {
       expect(
         downloadCenter.getAssets(config, 'ga')
           .map((asset) => path.basename(asset.download_link))
@@ -64,7 +64,7 @@ describe('CompassDownloadCenter', () => {
       ]);
     });
 
-    it('returns all the assets for beta', () => {
+    it('returns all the assets for beta', function() {
       expect(
         downloadCenter.getAssets(config, 'beta')
           .map((asset) => path.basename(asset.download_link))
@@ -91,8 +91,8 @@ describe('CompassDownloadCenter', () => {
     });
   });
 
-  describe('replaceVersion', () => {
-    it('replaces all stable version with the new one', async() => {
+  describe('replaceVersion', function() {
+    it('replaces all stable version with the new one', async function() {
       const expected = await fs.readJSON(
         path.resolve(__dirname, 'fixtures', 'expected-ga.json')
       );
@@ -101,7 +101,7 @@ describe('CompassDownloadCenter', () => {
       expect(updated).to.deep.equal(expected);
     });
 
-    it('replaces all beta versions with the new one', async() => {
+    it('replaces all beta versions with the new one', async function() {
       const expected = await fs.readJSON(
         path.resolve(__dirname, 'fixtures', 'expected-beta.json')
       );