Revert "feat(connections): Save connection on successful connection COMPASS-5267 (#2595)" (#2608)

This reverts commit c7c5910.

Author: Anemy

package-lock.json

@@ -1 +1 @@
-module.exports = require('@mongodb-js/mocha-config-compass/compass-plugin');
+module.exports = require('@mongodb-js/mocha-config-compass/react');

packages/connections/.mocharc.js

@@ -40,8 +40,12 @@
     "depcheck": "depcheck",
     "check": "npm run lint && npm run depcheck",
     "check-ci": "npm run check",
+    "pretest": "mongodb-runner start --port=27018 && node ../../scripts/rebuild.js keytar",
     "test": "mocha",
+    "posttest": "mongodb-runner stop --port=27018",
+    "pretest-electron": "mongodb-runner start --port=27018 && node ../../scripts/rebuild.js keytar",
     "test-electron": "xvfb-maybe electron-mocha --no-sandbox",
+    "posttest-electron": "mongodb-runner stop --port=27018",
     "test-cov": "nyc -x \"**/*.spec.*\" npm run test",
     "test-watch": "npm run test -- --watch",
     "test-ci": "npm run test-electron && npm run test-cov",
@@ -79,8 +83,10 @@
     "chai": "^4.3.4",
     "depcheck": "^1.4.1",
     "eslint": "^7.25.0",
+    "get-port": "^5.1.1",
     "mocha": "^8.4.0",
     "mongodb-data-service": "^21.13.0",
+    "mongodb-runner": "^4.8.3",
     "nyc": "^15.1.0",
     "prettier": "2.3.2",
     "rimraf": "^3.0.2",

packages/connections/package.json

@@ -5,11 +5,12 @@ import sinon from 'sinon';
 
 import Connecting from './connecting';
 
+const delay = (amt) => new Promise((resolve) => setTimeout(resolve, amt));
+
 describe('Connecting Component', function () {
   let onCancelConnectionClickedSpy;
 
   beforeEach(function () {
-    this.clock = sinon.useFakeTimers();
     onCancelConnectionClickedSpy = sinon.spy();
   });
 
@@ -19,7 +20,6 @@ describe('Connecting Component', function () {
   });
 
   afterEach(function () {
-    this.clock.restore();
     // Modals can have delays and transitions so it's best to cleanup.
     cleanup();
   });
@@ -47,9 +47,8 @@ describe('Connecting Component', function () {
     });
 
     describe('after a slight delay', function () {
-      beforeEach(function () {
-        // Speedup the modal showing annimation.
-        this.clock.tick(300);
+      beforeEach(async function () {
+        await delay(300);
       });
 
       it('shows the connecting modal', function () {

packages/connections/src/components/connecting/connecting.spec.tsx

@@ -75,6 +75,7 @@ function Connecting({
           <ConnectingAnimation />
           <Link
             as="button"
+            data-testid="cancel-connection-attempt-button"
             onClick={onCancelConnectionClicked}
             hideExternalIcon
             className={cancelButtonStyles}