use switch-exhaustiveness-check, add updatemanu to fixtures

Author: lerouxb

packages/compass-saved-aggregations-queries/.eslintrc.js

@@ -6,4 +6,12 @@ module.exports = {
     tsconfigRootDir: __dirname,
     project: ['./tsconfig-lint.json'],
   },
+  overrides: [
+    {
+      files: ['**/*.ts'],
+      rules: {
+        '@typescript-eslint/switch-exhaustiveness-check': 'error',
+      },
+    },
+  ],
 };

packages/compass-saved-aggregations-queries/src/index.spec.tsx

@@ -41,7 +41,7 @@ function getConnection() {
   };
 }
 
-describe('AggregationsQueriesList', function () {
+describe('AggregationsAndQueriesAndUpdatemanyList', function () {
   const sandbox = Sinon.createSandbox();
   const query = {
     _id: '123',
@@ -51,6 +51,14 @@ describe('AggregationsQueriesList', function () {
     filter: { foo: 'bar' },
     sort: { bar: -1 },
   } as any;
+  const updatemany = {
+    _id: '5667',
+    _name: 'Updatemany',
+    _ns: 'bar.baz',
+    _dateSaved: new Date(),
+    filter: { foo: 'baz' },
+    sort: { baz: -1 },
+  } as any;
   const aggregation = {
     id: '123',
     name: 'Aggregation',
@@ -153,7 +161,7 @@ describe('AggregationsQueriesList', function () {
   });
 
   it('should load queries and display them in the list', async function () {
-    sandbox.stub(queryStorage, 'loadAll').resolves([query]);
+    sandbox.stub(queryStorage, 'loadAll').resolves([query, updatemany]);
     renderPlugin();
     expect(await screen.findByText('Query')).to.exist;
     await waitFor(() => expect(screen.findByText(query._name)).to.exist);
@@ -168,7 +176,7 @@ describe('AggregationsQueriesList', function () {
 
   describe('copy to clipboard', function () {
     it('should copy query to the clipboard', async function () {
-      sandbox.stub(queryStorage, 'loadAll').resolves([query]);
+      sandbox.stub(queryStorage, 'loadAll').resolves([query, updatemany]);
       renderPlugin();
       expect(await screen.findByText(query._name)).to.exist;
 
@@ -386,7 +394,7 @@ describe('AggregationsQueriesList', function () {
     };
 
     beforeEach(function () {
-      sandbox.stub(queryStorage, 'loadAll').resolves([query]);
+      sandbox.stub(queryStorage, 'loadAll').resolves([query, updatemany]);
     });
 
     context('when not connected to any connection', function () {

packages/compass-saved-aggregations-queries/src/stores/delete-item.ts

@@ -55,11 +55,14 @@ export const confirmDeleteItem = (
       undefined // this event is connection scoped when triggered from the aggregation or query screen
     );
 
-    if (item.type === 'aggregation') {
-      await pipelineStorage?.delete(item.id);
-    } else {
-      // query or updatemany
-      await queryStorage?.delete(item.id);
+    switch (item.type) {
+      case 'aggregation':
+        await pipelineStorage?.delete(item.id);
+        break;
+      case 'query':
+      case 'updatemany':
+        await queryStorage?.delete(item.id);
+        break;
     }
 
     dispatch({ type: ActionTypes.DeleteItemConfirm, id: item.id });

packages/compass-saved-aggregations-queries/src/stores/edit-item.ts

@@ -87,14 +87,17 @@ export const updateItem =
       return;
     }
 
-    if (item.type === 'aggregation') {
-      await pipelineStorage?.updateAttributes(id, attributes);
-    } else {
-      // query or updatemany
-      await queryStorage?.updateAttributes(id, {
-        _name: attributes.name,
-        _dateModified: new Date(),
-      });
+    switch (item.type) {
+      case 'aggregation':
+        await pipelineStorage?.updateAttributes(id, attributes);
+        break;
+      case 'query':
+      case 'updatemany':
+        await queryStorage?.updateAttributes(id, {
+          _name: attributes.name,
+          _dateModified: new Date(),
+        });
+        break;
     }
 
     dispatch({

packages/compass-saved-aggregations-queries/src/stores/open-item.ts

@@ -568,13 +568,16 @@ export const openSelectedItem =
       const id = selectedItem.id;
       const newNamespace = `${selectedDatabase}.${selectedCollection}`;
 
-      if (selectedItem.type === 'aggregation') {
-        await pipelineStorage?.updateAttributes(id, {
-          namespace: newNamespace,
-        });
-      } else {
-        // query or updatemany
-        await queryStorage?.updateAttributes(id, { _ns: newNamespace });
+      switch (selectedItem.type) {
+        case 'aggregation':
+          await pipelineStorage?.updateAttributes(id, {
+            namespace: newNamespace,
+          });
+          break;
+        case 'query':
+        case 'updatemany':
+          await queryStorage?.updateAttributes(id, { _ns: newNamespace });
+          break;
       }
     }
 

packages/compass-saved-aggregations-queries/test/fixtures.ts

@@ -97,6 +97,37 @@ export const queries = [
       },
     },
   },
+  {
+    id: '9999',
+    name: 'update some things',
+    database: 'airbnb',
+    collection: 'hosts',
+    lastModified: 13,
+    type: 'updatemany' as const,
+    query: {
+      _id: '9012',
+      _name: 'update some things',
+      _ns: 'airbnb.hosts',
+      _dateSaved: DATE,
+      _dateModified: DATE,
+      _lastExecuted: DATE,
+      filter: {
+        host_location: RegExp('berlin'),
+      },
+      project: {
+        id: 1,
+        name: 1,
+      },
+      sort: {
+        reviews: -1,
+      },
+      skip: 0,
+      limit: 10,
+      collation: {
+        locale: 'simple',
+      },
+    },
+  },
 ];
 
 export const pipelines = [