redundant checks

lerouxb · lerouxb · commit b7e2b8131f1b · 2025-09-25T16:38:16.000+01:00
diff --git a/packages/compass-components/src/components/drawer-portal.tsx b/packages/compass-components/src/components/drawer-portal.tsx
@@ -157,17 +157,11 @@ export const DrawerContentProvider: React.FunctionComponent<{
       return;
     }
 
-    if (
-      drawerCurrentTab &&
-      drawerCurrentTab !== prevDrawerCurrentTabRef.current
-    ) {
+    if (drawerCurrentTab) {
       onDrawerSectionOpen?.(drawerCurrentTab);
     }
 
-    if (
-      prevDrawerCurrentTabRef.current &&
-      drawerCurrentTab !== prevDrawerCurrentTabRef.current
-    ) {
+    if (prevDrawerCurrentTabRef.current) {
       onDrawerSectionHide?.(prevDrawerCurrentTabRef.current);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -157,17 +157,11 @@ export const DrawerContentProvider: React.FunctionComponent<{`
`157`	`157`	`return;`
`158`	`158`	`}`
`159`	`159`
`160`		`- if (`
`161`		`- drawerCurrentTab &&`
`162`		`- drawerCurrentTab !== prevDrawerCurrentTabRef.current`
`163`		`- ) {`
	`160`	`+ if (drawerCurrentTab) {`
`164`	`161`	`onDrawerSectionOpen?.(drawerCurrentTab);`
`165`	`162`	`}`
`166`	`163`
`167`		`- if (`
`168`		`- prevDrawerCurrentTabRef.current &&`
`169`		`- drawerCurrentTab !== prevDrawerCurrentTabRef.current`
`170`		`- ) {`
	`164`	`+ if (prevDrawerCurrentTabRef.current) {`
`171`	`165`	`onDrawerSectionHide?.(prevDrawerCurrentTabRef.current);`
`172`	`166`	`}`
`173`	`167`