hack some more

Author: lerouxb

package-lock.json

@@ -13,5 +13,7 @@ ignores: [
     'mongodb-client-encryption',
     'interruptor',
     # webpack always externalizes 'clipboard' for legacy reasons
-    'clipboard'
+    'clipboard',
+    # include signing-utils so that signtool.go can get to it
+    '@mongodb-js/signing-utils'
   ]

packages/compass/.depcheckrc

@@ -231,6 +231,7 @@
     "@mongodb-js/my-queries-storage": "^0.22.0",
     "@mongodb-js/prettier-config-compass": "^1.2.0",
     "@mongodb-js/sbom-tools": "^0.7.0",
+    "@mongodb-js/signing-utils": "^0.3.7",
     "@mongodb-js/testing-library-compass": "^1.2.0",
     "@mongodb-js/tsconfig-compass": "^1.2.0",
     "@mongodb-js/webpack-config-compass": "^1.6.0",

packages/compass/package.json

@@ -436,20 +436,7 @@ class Target {
       );
 
       const electronWinstaller = require('electron-winstaller');
-
-      // We monkey-patch the signtool.exe that comes with electron-winstaller
-      // with our drop-in replace ment signtool.exe written in go so that
-      // electron-winstaller will execute that. But it requires
-      // @mongodb-js/signing-tools via node and that's only a dep of this
-      // package. So change the working directory to packages/hadron-build so
-      // that that would work.
-      const oldCWD = process.cwd();
-      process.chdir(path.join(__dirname, '..', '..'));
-      try {
-        await electronWinstaller.createWindowsInstaller(this.installerOptions);
-      } finally {
-        process.chdir(oldCWD);
-      }
+      await electronWinstaller.createWindowsInstaller(this.installerOptions);
 
       await fs.promises.rename(
         this.dest('RELEASES'),

packages/hadron-build/lib/target.js

@@ -66,7 +66,11 @@ func main() {
 	if err != nil {
 		fmt.Println("Error signing the file")
 		fmt.Printf("%s\n", stdoutStderr)
-		log.Fatal(err)
+		log.Println(err)
+		// if we error out then we won't see much because of how
+		// electron-windows-installer fails. We'll have to rely on package
+		// verification elsewhere to fail CI
+		return
 	}
 
 	fmt.Println("File signed successfully.")