Skip to content

Commit bf863aa

Browse files
committed
INT-1580 fix migration fail for beta (#431)
(cherry picked from commit ebca473)
1 parent 5e618e7 commit bf863aa

File tree

2 files changed

+5
-8
lines changed

2 files changed

+5
-8
lines changed

src/main/migrations/1.2.0.js

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,17 +17,14 @@ function changeUserDataDirectoryLocation(done) {
1717
// check if old preferences directory exists
1818
var oldUserDir = path.join(app.getPath('appData'), oldDir);
1919
var newUserDir = app.getPath('userData');
20-
try {
21-
ncp(oldUserDir, newUserDir, function(errCp) {
20+
21+
ncp(oldUserDir, newUserDir, {clobber: false, stopOnErr: true},
22+
function(errCp) {
2223
if (errCp) {
2324
return done(errCp);
2425
}
2526
done();
2627
});
27-
} catch (e) {
28-
// failed migration, handle gracefully
29-
done(new Error('Failed migration ChangeUserDataDirectoryLocation: ' + e.message));
30-
}
3128
}
3229

3330
module.exports = function(previousVersion, currentVersion, callback) {
@@ -36,6 +33,6 @@ module.exports = function(previousVersion, currentVersion, callback) {
3633
if (err) {
3734
return callback(err);
3835
}
39-
callback(null, 'successful migration to 1.2.0');
36+
callback(null, 'successful migration to 1.2.0-beta.1');
4037
});
4138
};

src/main/migrations/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ var storageMixin = require('storage-mixin');
44
var electronApp = require('electron').app;
55

66
var migrations = {
7-
'1.2.0': require('./1.2.0')
7+
'1.2.0-beta.1': require('./1.2.0')
88
};
99

1010
var migrate = require('app-migrations')(migrations);

0 commit comments

Comments
 (0)