disable overlay for e2e tests

Author: paula-stacho

configs/webpack-config-compass/src/index.ts

@@ -276,10 +276,10 @@ export function createElectronRendererConfig(
               writeToDisk: true,
             },
             client: {
-              overlay: {
-                errors: true,
-                warnings: false,
-              },
+              overlay:
+                process.env.DISABLE_DEVSERVER_OVERLAY === 'true'
+                  ? false
+                  : { warnings: false, errors: true, runtimeErrors: true },
             },
             https: false,
             hot: opts.hot,

packages/compass-e2e-tests/helpers/compass-web-sandbox.ts

@@ -19,7 +19,7 @@ const debug = Debug('compass-e2e-tests:compass-web-sandbox');
  * with webdriver will get the values
  */
 process.env.OPEN_BROWSER = 'false'; // tell webpack dev server not to open the default browser
-process.env.DISABLE_DEVSERVER_OVERLAY = 'false';
+process.env.DISABLE_DEVSERVER_OVERLAY = 'true';
 process.env.APP_ENV = 'webdriverio';
 
 const wait = (ms: number) => {

packages/compass-e2e-tests/helpers/compass.ts

@@ -645,6 +645,7 @@ async function startCompassElectron(
   const maybeWrappedBinary = (await opts.wrapBinary?.(binary)) ?? binary;
 
   process.env.APP_ENV = 'webdriverio';
+  process.env.DISABLE_DEVSERVER_OVERLAY = 'true';
   // For webdriverio env we are changing appName so that keychain records do not
   // overlap with anything else. But leave it alone when testing auto-update.
   if (!process.env.HADRON_AUTO_UPDATE_ENDPOINT_OVERRIDE) {