Skip to content

Commit c3ae95e

Browse files
two dismissible banners
1 parent fbd1b77 commit c3ae95e

File tree

2 files changed

+31
-6
lines changed

2 files changed

+31
-6
lines changed

packages/compass-indexes/src/components/indexes/indexes.tsx

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,13 +49,23 @@ const containerStyles = css({
4949

5050
const linkTitle = 'Atlas Search.';
5151

52+
const DIMISSED_SEARCH_INDEXES_BANNER_LOCAL_STORAGE_KEY =
53+
'dismissedSearchIndexesBanner';
54+
5255
const AtlasIndexesBanner = ({ namespace }: { namespace: string }) => {
5356
const { atlasMetadata } = useConnectionInfo();
5457
if (!atlasMetadata) {
5558
return null;
5659
}
60+
const onClose = () => {
61+
localStorage.setItem(
62+
DIMISSED_SEARCH_INDEXES_BANNER_LOCAL_STORAGE_KEY,
63+
'true'
64+
);
65+
};
5766
return (
58-
<Banner variant="info">
67+
// one
68+
<Banner variant="info" dismissible onClose={onClose}>
5969
<Body weight="medium">Looking for search indexes?</Body>
6070
These indexes can be created and viewed under{' '}
6171
{atlasMetadata ? (
@@ -141,9 +151,11 @@ export function Indexes({
141151
}
142152
>
143153
<div className={indexesContainersStyles}>
144-
{!isReadonlyView && !enableAtlasSearchIndexes && (
145-
<AtlasIndexesBanner namespace={namespace} />
146-
)}
154+
{!isReadonlyView &&
155+
!enableAtlasSearchIndexes &&
156+
localStorage.getItem(
157+
DIMISSED_SEARCH_INDEXES_BANNER_LOCAL_STORAGE_KEY
158+
) !== 'true' && <AtlasIndexesBanner namespace={namespace} />}
147159
{!isReadonlyView && currentIndexesView === 'regular-indexes' && (
148160
<RegularIndexesTable />
149161
)}

packages/compass-schema/src/components/compass-schema.tsx

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,9 @@ const insightsBadgeStyles = css({
7474
verticalAlign: 'middle',
7575
});
7676

77+
const DISMISSED_PERFORMANCE_ADVISOR_BANNER_LOCAL_STORAGE_KEY =
78+
'dismissedPerformanceAdvisorBanner' as const;
79+
7780
const minichartStyles = (darkMode: boolean) => {
7881
const mcBlue0 = palette.blue.light1;
7982
const mcBlue1 = lighten(0.075, mcBlue0);
@@ -341,8 +344,15 @@ const title = 'Atlas’ Performance Advisor.';
341344
const PerformanceAdvisorBanner = () => {
342345
const connectionInfo = useConnectionInfo();
343346
const track = useTelemetry();
347+
const onClose = () => {
348+
localStorage.setItem(
349+
DISMISSED_PERFORMANCE_ADVISOR_BANNER_LOCAL_STORAGE_KEY,
350+
'true'
351+
);
352+
};
344353
return (
345-
<Banner variant="info">
354+
// two
355+
<Banner variant="info" dismissible onClose={onClose}>
346356
<Body weight="medium">Looking for schema anti-patterns?</Body>
347357
In its place, you may refer to Data Explorer’s performance insights{' '}
348358
<Badge className={insightsBadgeStyles} variant="blue">
@@ -413,7 +423,10 @@ const Schema: React.FunctionComponent<{
413423
}
414424
>
415425
<div className={contentStyles}>
416-
{enablePerformanceAdvisorBanner && <PerformanceAdvisorBanner />}
426+
{enablePerformanceAdvisorBanner &&
427+
localStorage.getItem(
428+
DISMISSED_PERFORMANCE_ADVISOR_BANNER_LOCAL_STORAGE_KEY
429+
) !== 'true' && <PerformanceAdvisorBanner />}
417430
{analysisState === ANALYSIS_STATE_INITIAL && (
418431
<InitialScreen onApplyClicked={onApplyClicked} />
419432
)}

0 commit comments

Comments
 (0)