add inferNamespacesFromPrivileges, default to true

Author: lerouxb

package-lock.json

@@ -83,7 +83,7 @@ interface CollectionProps {
   sourceName: string | null;
   source: Collection;
   properties: { id: string; options?: Record<string, unknown> }[];
-  is_non_existent: boolean;
+  is_ghost_namespace: boolean;
 }
 
 type CollectionDataService = Pick<

packages/collection-model/index.d.ts

@@ -102,7 +102,7 @@ function pickCollectionInfo({
   validation,
   clustered,
   fle2,
-  is_non_existent,
+  is_ghost_namespace,
 }) {
   return {
     type,
@@ -113,7 +113,7 @@ function pickCollectionInfo({
     validation,
     clustered,
     fle2,
-    is_non_existent,
+    is_ghost_namespace,
   };
 }
 
@@ -135,7 +135,7 @@ const CollectionModel = AmpersandModel.extend(debounceActions(['fetch']), {
     statusError: { type: 'string', default: null },
 
     // Normalized values from collectionInfo command
-    is_non_existent: 'boolean',
+    is_ghost_namespace: 'boolean',
     readonly: 'boolean',
     clustered: 'boolean',
     fle2: 'boolean',
@@ -286,14 +286,14 @@ const CollectionModel = AmpersandModel.extend(debounceActions(['fetch']), {
         ...collStats,
         ...(collectionInfo && pickCollectionInfo(collectionInfo)),
       });
-      // If the collection is not unprovisioned `is_non_existent` anymore,
+      // If the collection is not unprovisioned `is_ghost_namespace` anymore,
       // let's update the parent database model to reflect the change.
       // This happens when a user tries to insert first document into a
       // collection that doesn't exist yet or creates a new collection
       // for an unprovisioned database.
-      if (!this.is_non_existent) {
+      if (!this.is_ghost_namespace) {
         getParentByType(this, 'Database').set({
-          is_non_existent: false,
+          is_ghost_namespace: false,
         });
       }
     } catch (err) {
@@ -385,6 +385,11 @@ const CollectionCollection = AmpersandCollection.extend(
     async fetch({ dataService }) {
       const databaseName = getParentByType(this, 'Database')?.getId();
 
+      const shouldFetchNamespacesFromPrivileges = getParentByType(
+        this,
+        'Instance'
+      ).shouldFetchNamespacesFromPrivileges;
+
       if (!databaseName) {
         throw new Error(
           `Trying to fetch ${this.modelType} that doesn't have the Database parent model`
@@ -405,6 +410,7 @@ const CollectionCollection = AmpersandCollection.extend(
         {
           // Always fetch collections with info
           nameOnly: false,
+          fetchNamespacesFromPrivileges: shouldFetchNamespacesFromPrivileges,
           privileges: instanceModel.auth.privileges,
         }
       );

packages/collection-model/lib/model.js

@@ -286,6 +286,16 @@ export function createInstancesStore(
     }
   );
 
+  preferences.onPreferenceValueChanged('inferNamespacesFromPrivileges', () => {
+    const connectedConnectionIds = Array.from(
+      instancesManager.listMongoDBInstances().keys()
+    );
+
+    for (const connectionId of connectedConnectionIds) {
+      void refreshDatabases({ connectionId });
+    }
+  });
+
   on(connections, 'disconnected', function (connectionInfoId: string) {
     try {
       const instance =

packages/compass-app-stores/src/stores/instance-store.ts

@@ -24,7 +24,7 @@ type PluginTitleProps = {
 
 function PluginTitle({
   editViewName,
-  isNonExistent,
+  isGhostNamespace,
   isReadonly,
   isTimeSeries,
   sourceName,
@@ -68,12 +68,12 @@ function PluginTitle({
           ? 'Visibility'
           : collectionType === 'timeseries'
           ? 'TimeSeries'
-          : isNonExistent
+          : isGhostNamespace
           ? 'EmptyFolder'
           : 'Folder'
       }
       data-namespace={ns}
-      isNonExistent={isNonExistent}
+      isGhostNamespace={isGhostNamespace}
     />
   );
 }

packages/compass-collection/src/plugin-tab-title.tsx

@@ -184,7 +184,7 @@ export type WorkspaceTabPluginProps = {
   connectionName?: string;
   type: string;
   title: React.ReactNode;
-  isNonExistent?: boolean;
+  isGhostNamespace?: boolean;
   iconGlyph: GlyphName | 'Logo' | 'Server';
   tooltip?: [string, string][];
 };
@@ -206,7 +206,7 @@ function Tab({
   type,
   title,
   tooltip,
-  isNonExistent,
+  isGhostNamespace,
   isSelected,
   isDragging,
   onSelect,
@@ -271,7 +271,7 @@ function Tab({
           className={cx(
             tabStyles,
             themeClass,
-            isNonExistent && nonExistentStyles,
+            isGhostNamespace && nonExistentStyles,
             isSelected && selectedTabStyles,
             isSelected && tabTheme && selectedThemedTabStyles,
             isDragging && draggingTabStyles,

packages/compass-components/src/components/workspace-tabs/tab.tsx

@@ -43,7 +43,7 @@ const connections: Connection[] = [
         collectionsStatus: 'initial',
         collectionsLength: 5,
         collections: [],
-        isNonExistent: false,
+        isGhostNamespace: false,
       },
       {
         _id: 'db_ready',
@@ -57,26 +57,26 @@ const connections: Connection[] = [
             type: 'collection',
             sourceName: '',
             pipeline: [],
-            isNonExistent: false,
+            isGhostNamespace: false,
           },
           {
             _id: 'db_ready.woof',
             name: 'woof',
             type: 'timeseries',
             sourceName: '',
             pipeline: [],
-            isNonExistent: false,
+            isGhostNamespace: false,
           },
           {
             _id: 'db_ready.bwok',
             name: 'bwok',
             type: 'view',
             sourceName: '',
             pipeline: [],
-            isNonExistent: false,
+            isGhostNamespace: false,
           },
         ],
-        isNonExistent: false,
+        isGhostNamespace: false,
       },
     ],
     isReady: true,

packages/compass-connections-navigation/src/connections-navigation-tree.spec.tsx

@@ -35,7 +35,7 @@ const IconWithTooltip = ({
 
 export const NavigationItemIcon = ({ item }: { item: SidebarTreeItem }) => {
   if (item.type === 'database') {
-    if (item.isNonExistent) {
+    if (item.isGhostNamespace) {
       return (
         <IconWithTooltip
           text={NON_EXISTANT_NAMESPACE_TEXT}
@@ -46,7 +46,7 @@ export const NavigationItemIcon = ({ item }: { item: SidebarTreeItem }) => {
     return <Icon glyph="Database" />;
   }
   if (item.type === 'collection') {
-    if (item.isNonExistent) {
+    if (item.isGhostNamespace) {
       return (
         <IconWithTooltip
           text={NON_EXISTANT_NAMESPACE_TEXT}

packages/compass-connections-navigation/src/navigation-item-icon.tsx

@@ -41,22 +41,26 @@ export default function StyledNavigationItem({
       !showDisabledConnections || getConnectable(connectionId);
     const isDisconnectedConnection =
       item.type === 'connection' && item.connectionStatus !== 'connected';
-    const isNonExistentNamespace =
+    const isGhostNamespaceNamespace =
       (item.type === 'database' || item.type === 'collection') &&
-      item.isNonExistent;
+      item.isGhostNamespace;
 
     if (colorCode && colorCode !== DefaultColorCode) {
       style['--item-bg-color'] = connectionColorToHex(colorCode);
       style['--item-bg-color-hover'] = connectionColorToHexActive(colorCode);
       style['--item-bg-color-active'] = connectionColorToHexActive(colorCode);
     }
 
-    if (isDisconnectedConnection || isNonExistentNamespace || !isConnectable) {
+    if (
+      isDisconnectedConnection ||
+      isGhostNamespaceNamespace ||
+      !isConnectable
+    ) {
       style['--item-color'] = inactiveColor;
     }
 
     // We always show these as inactive
-    if (isNonExistentNamespace || !isConnectable) {
+    if (isGhostNamespaceNamespace || !isConnectable) {
       style['--item-color-active'] = inactiveColor;
     }
     return style;