Merge branch 'main' into autoupdate-from3

Author: lerouxb

.evergreen/functions.yml

@@ -152,8 +152,6 @@ functions:
 
           # Make all the dirs
           mkdir -p $ARTIFACTS_PATH
-          mkdir -p $NPM_CACHE_DIR
-          mkdir -p $NPM_TMP_DIR
 
     - command: shell.exec
       type: setup
@@ -195,18 +193,9 @@ functions:
           npm config ls -l
           echo "(if npm fails, debug.log will be uploaded to S3)"
 
-          # Install dependencies
+          # Install and check dependencies
           bash ".evergreen/retry-with-backoff.sh" .evergreen/npm_ci.sh
 
-          # Will fail if versions of direct dependencies listed in package-lock
-          # are not matching versions defined in package.json file of any of the
-          # workspace packages
-          # This command is very noisy when running from root with --all, store
-          # the output in a file that will be uploaded with rest of the logs
-          LS_ALL_STDOUT_FILE="$(npm config get cache)/_logs/$(date -u +"%Y-%m-%dT%H_%M_%SZ")-npm-ls-all.log"
-          echo "Validating dependencies with \`npm ls --all\`..."
-          (npm ls --all > $LS_ALL_STDOUT_FILE && echo "No mismatched dependency versions") || echo "\nThe \`npm ls\` command failed with mismatched dependencies error. This usually means that the dependency versions listed in package.json are not matching dependencies resolved and recorded in package-lock.json. If you updated package.json files in your PR, inspect the error output and try to re-install offending dependncies to fix the package-lock file."
-
   bootstrap:
     - command: shell.exec
       type: setup

.evergreen/npm_ci.sh

@@ -2,9 +2,20 @@
 
 set -e
 
-npm cache clean -f
+# Remove the cache and any potential install leftovers before installing again.
+# We are running this script with a retry to deal with network issues, in some
+# rare cases npm leaves stuff behind messing up a new attempt
+rm -rf "$NPM_CACHE_DIR"
 rm -rf node_modules
 find configs -name 'node_modules' -type d -prune -exec rm -rf '{}' +
 find packages -name 'node_modules' -type d -prune -exec rm -rf '{}' +
 find scripts -name 'node_modules' -type d -prune -exec rm -rf '{}' +
-npm ci --unsafe-perm
+npm ci --unsafe-perm
+
+# Will fail if versions of direct dependencies listed in package-lock are not
+# matching versions defined in package.json file of any of the workspace
+# packages. This command is very noisy when running from root with --all, store
+# the output in a file that will be uploaded with rest of the logs
+LS_ALL_STDOUT_FILE="$(npm config get cache)/_logs/$(date -u +"%Y-%m-%dT%H_%M_%SZ")-npm-ls-all.log"
+echo "Validating dependencies with \`npm ls --all\`..."
+(npm ls --all >$LS_ALL_STDOUT_FILE && echo "No mismatched dependency versions") || (echo ""; echo "The \`npm ls\` command failed with mismatched dependencies error. This usually means that the dependency versions listed in package.json are not matching dependencies resolved and recorded in package-lock.json. If you updated package.json files in your PR, inspect the error output and try to re-install offending dependncies to fix the package-lock file." && exit 1)

.evergreen/print-compass-env.js

@@ -1,5 +1,6 @@
 #! /usr/bin/env node
 'use strict';
+const path = require('path');
 
 /*
 This script writes a bash script that can be eval()'d in evergreen to modify the
@@ -79,18 +80,16 @@ function printCompassEnv() {
   PATH = maybePrependPaths(PATH, pathsToPrepend);
   printVar('PATH', PATH);
 
-  const npmCacheDir = `${newPWD}/.deps/.npm`;
-  const npmTmpDir = `${newPWD}/.deps/tmp`;
+  // not using `newPWD` here to avoid issues on windows where the value supposed
+  // to be a non-cygwin path
+  const npmCacheDir = path.resolve(__dirname, '..', '.deps', '.npm-cache');
 
   printVar('ARTIFACTS_PATH', `${newPWD}/.deps`);
   printVar('NPM_CACHE_DIR', npmCacheDir);
-  printVar('NPM_TMP_DIR', npmTmpDir);
 
   // all npm var names need to be lowercase
   // see: https://docs.npmjs.com/cli/v7/using-npm/config#environment-variables
   printVar('npm_config_cache', npmCacheDir);
-  // npm tmp is deprecated, but let's keep it around just in case
-  printVar('npm_config_tmp', npmTmpDir);
   // Also set in our .npmrc but that does not get picked up in the preinstall script.
   printVar('npm_config_registry', 'https://registry.npmjs.org/');
 

.github/workflows/authors-and-third-party-notices.yaml

@@ -8,6 +8,9 @@ on:
     branches:
       - main
 
+permissions:
+  contents: none # We use the github app token to push the changes
+
 jobs:
   update_generated_files:
     name: Update automatically generated files

.github/workflows/bump-packages.yaml

@@ -5,6 +5,9 @@ on:
     branches:
       - main
 
+permissions:
+  contents: none # We use the github app token to open the PR
+
 jobs:
   update_generated_files:
     name: Bump packages
@@ -21,6 +24,7 @@ jobs:
         with:
           # don't checkout a detatched HEAD
           ref: ${{ github.head_ref }}
+          token: ${{ steps.app-token.outputs.token }}
 
       - uses: actions/setup-node@v4
         with:
@@ -38,12 +42,8 @@ jobs:
 
       - name: Bump packages
         env:
-          LAST_BUMP_COMMIT_MESSAGE: "chore(release): bump package versions"
           SKIP_BUMP_PACKAGES: "mongodb-compass"
-        run: |
-          npm run bump-packages
-          git add .
-          git commit --no-allow-empty -m "$LAST_BUMP_COMMIT_MESSAGE" || true
+        run: npm run bump-packages
 
       - name: Create Pull Request
         uses: peter-evans/create-pull-request@5e914681df9dc83aa4e4905692ca88beb2f9e91f # 7.0.5
@@ -53,5 +53,6 @@ jobs:
           branch: ci/bump-packages
           title: "chore(release): bump package versions"
           labels: no-title-validation
+          author: "${{ steps.app-token.outputs.app-slug}}[bot] <${{ steps.app-token.outputs.app-email }}>"
           body: |
             - Bump package versions

.github/workflows/check-pr-title.yml

@@ -3,22 +3,25 @@ on:
   pull_request:
     types: [opened, synchronize, reopened, ready_for_review, labeled, unlabeled, converted_to_draft, edited]
 
+permissions:
+  pull-requests: read # to read the PR title and labels
+
 jobs:
   check-pr-title:
     name: Check PR Title
     runs-on: ubuntu-latest
     steps:
       - name: Enforce conventional commit style
-        uses: realm/ci-actions/title-checker@main
+        uses: realm/ci-actions/title-checker@d6cc8f067474759d38e6d24e272027b4c88bc0a9
         with:
           regex: '^(build|chore|ci|docs|feat|fix|perf|refactor|revert|style|test|ops){1}(\([\w\-\.]+\))?(!)?: .*'
           error-hint: 'Invalid PR title. Make sure it follows the conventional commit specification (i.e. "<type>(<optional scope>): <description>") or add the no-title-validation label'
-          ignore-labels: 'no-title-validation'
+          ignore-labels: "no-title-validation"
       - name: Enforce JIRA ticket in title
-        uses: realm/ci-actions/title-checker@main
+        uses: realm/ci-actions/title-checker@d6cc8f067474759d38e6d24e272027b4c88bc0a9
         # Skip the JIRA ticket check for PRs opened by bots
         if: ${{ !contains(github.event.pull_request.user.login, '[bot]') }}
         with:
-          regex: '[A-Z]{4,10}-[0-9]{1,10}$'
-          error-hint: 'Invalid PR title. Make sure it ends with a JIRA ticket - i.e. COMPASS-1234 or add the no-title-validation label'
-          ignore-labels: 'no-title-validation'
+          regex: "[A-Z]{4,10}-[0-9]{1,10}$"
+          error-hint: "Invalid PR title. Make sure it ends with a JIRA ticket - i.e. COMPASS-1234 or add the no-title-validation label"
+          ignore-labels: "no-title-validation"

.github/workflows/codeql.yml

@@ -1,23 +1,15 @@
-# For most projects, this workflow file will not need changing; you simply need
-# to commit it to your repository.
-#
-# You may wish to alter this file to override the set of languages analyzed,
-# or to provide custom queries or build logic.
-#
-# ******** NOTE ********
-# We have attempted to detect the languages in your repository. Please check
-# the `language` matrix defined below to confirm you have the correct set of
-# supported CodeQL languages.
-#
-name: "CodeQL"
+name: CodeQL
 
 on:
   push:
-    branches: ["main", "*-releases"]
-    tags: ["v*"]
+    branches:
+      - main
+      - "*-releases"
+    tags:
+      - v*
   pull_request:
-    # The branches below must be a subset of the branches above
-    branches: ["main"]
+    branches:
+      - main
   schedule:
     - cron: "30 14 * * 4"
   workflow_dispatch:
@@ -26,8 +18,8 @@ on:
 jobs:
   analyze:
     name: Analyze
-    runs-on: ${{ (matrix.language == 'swift' && 'macos-latest') || 'ubuntu-latest' }}
-    timeout-minutes: ${{ (matrix.language == 'swift' && 120) || 360 }}
+    runs-on: ubuntu-latest
+    timeout-minutes: 360
     permissions:
       actions: read
       contents: read
@@ -36,26 +28,25 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        language: ["go", "javascript", "python"]
-        # CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python', 'ruby', 'swift' ]
-        # Use only 'java' to analyze code written in Java, Kotlin or both
-        # Use only 'javascript' to analyze code written in JavaScript, TypeScript or both
-        # Learn more about CodeQL language support at https://aka.ms/codeql-docs/language-support
+        include:
+          - language: go
+            build-mode: autobuild
+          - language: javascript
+            build-mode: none
+          - language: python
+            build-mode: none
+          - language: actions
+            build-mode: none
 
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
 
-      # Initializes the CodeQL tools for scanning.
       - name: Initialize CodeQL
-        uses: github/codeql-action/init@v2
+        uses: github/codeql-action/init@v3
         with:
           languages: ${{ matrix.language }}
-          # If you wish to specify custom queries, you can do so here or in a config file.
-          # By default, queries listed here will override any specified in a config file.
-          # Prefix the list here with "+" to use these queries and those in the config file.
-
-          # For more details on CodeQL's query packs, refer to: https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-code-scanning#using-queries-in-ql-packs
+          build-mode: ${{ matrix.build-mode }}
           queries: security-extended
           config: |
             paths-ignore:
@@ -67,22 +58,7 @@ jobs:
               - '**/*.spec.tsx'
               - 'scripts/**'
 
-      # Autobuild attempts to build any compiled languages (C/C++, C#, Go, Java, or Swift).
-      # If this step fails, then you should remove it and run the build manually (see below)
-      - name: Autobuild
-        uses: github/codeql-action/autobuild@v2
-
-      # ℹ️ Command-line programs to run using the OS shell.
-      # 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun
-
-      #   If the Autobuild fails above, remove it and uncomment the following three lines.
-      #   modify them (or add more) to build your code if your project, please refer to the EXAMPLE below for guidance.
-
-      # - run: |
-      #     echo "Run, Build Application using script"
-      #     ./location_of_script_within_repo/buildscript.sh
-
       - name: Perform CodeQL Analysis
-        uses: github/codeql-action/analyze@v2
+        uses: github/codeql-action/analyze@v3
         with:
           category: "/language:${{matrix.language}}"

.github/workflows/merge-bump-packages-pr.yaml

@@ -5,6 +5,9 @@ on:
     # Each Tuesday at 5 AM UTC
     - cron: "0 5 * * 2"
 
+permissions:
+  contents: none # We use the github app token to merge the PR
+
 jobs:
   merge_bump_packages_pr:
     name: Merge bump packages PR

.github/workflows/publish-compass.yaml

@@ -11,6 +11,9 @@ on:
   release:
     types: [published]
 
+permissions:
+  contents: write # needed to publish the release
+
 jobs:
   publish:
     name: Publish updated manifest to download center

.github/workflows/publish-packages.yaml

@@ -9,6 +9,9 @@ on:
     branches:
       - main
 
+permissions:
+  contents: write # to push tags
+
 jobs:
   publish:
     if: |