Skip to content

Commit d583082

Browse files
authored
COMPASS-1393 Backport COMPASS-1340 "dev"-only chartView (#1141) (#1143)
* COMPASS-1340 "dev"-only chartView (#1141) * 🎨 Make preferencesProps into a local variable * 🎉 COMPASS-1340 Only enable charts in development builds * Simulate bumping to a beta https://github.com/10gen/compass-internal-docs/blob/master/release-process/promote-master-to-beta.md * Revert "Simulate bumping to a beta" * 🔥 Remove test/functional/charts.test.js * 🐛 Restore 'Chart.Chart' plugin component when charts tab is disabled By moving the 'Chart.Chart' component into the src/internal-packages/app global namespace, as has been done for 'Schema.FieldStore', and also moving the SPEC_TYPE_ENUM to app/lib/constants.js and renaming it to CHART_SPEC_TYPE_ENUM. * 🎨 Revert SPEC_TYPE_ENUM changes and hard-code 'vega' constant It's already hard-coded in the PropTypes validation: specType: PropTypes.oneOf(['vega', 'vega-lite']), * 🐛 COMPASS-1340 Handle stable versions too * 🐛 De-globalise Chart.Chart role * ✅ Add vega to dependencies (#1104) This should resolve the Travis build errors if the cache has been cleared: https://travis-ci.com/10gen/compass/jobs/80218874 vega is only a peerDependency of react-vega: https://github.com/kristw/react-vega/blob/v3.1.1/package.json Possibly related: COMPASS 942.
1 parent 185d2a2 commit d583082

File tree

5 files changed

+250
-330
lines changed

5 files changed

+250
-330
lines changed

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -204,6 +204,7 @@
204204
"turf-distance": "^1.1.0",
205205
"turf-point": "^2.0.1",
206206
"uuid": "^3.0.0",
207+
"vega": "^3.0.0-beta.30",
207208
"vega-lite": "^2.0.0-beta.4"
208209
},
209210
"devDependencies": {

0 commit comments

Comments
 (0)