Commit d583082
authored
* COMPASS-1340 "dev"-only chartView (#1141)
* 🎨 Make preferencesProps into a local variable
* 🎉 COMPASS-1340 Only enable charts in development builds
* Simulate bumping to a beta
https://github.com/10gen/compass-internal-docs/blob/master/release-process/promote-master-to-beta.md
* Revert "Simulate bumping to a beta"
* 🔥 Remove test/functional/charts.test.js
* 🐛 Restore 'Chart.Chart' plugin component when charts tab is disabled
By moving the 'Chart.Chart' component into the src/internal-packages/app global namespace, as has been done for 'Schema.FieldStore', and also moving the SPEC_TYPE_ENUM to app/lib/constants.js and renaming it to CHART_SPEC_TYPE_ENUM.
* 🎨 Revert SPEC_TYPE_ENUM changes and hard-code 'vega' constant
It's already hard-coded in the PropTypes validation:
specType: PropTypes.oneOf(['vega', 'vega-lite']),
* 🐛 COMPASS-1340 Handle stable versions too
* 🐛 De-globalise Chart.Chart role
* ✅ Add vega to dependencies (#1104)
This should resolve the Travis build errors if the cache has been cleared:
https://travis-ci.com/10gen/compass/jobs/80218874
vega is only a peerDependency of react-vega:
https://github.com/kristw/react-vega/blob/v3.1.1/package.json
Possibly related: COMPASS 942.
1 parent 185d2a2 commit d583082
File tree
5 files changed
+250
-330
lines changed- src
- app/models
- internal-packages/chart/lib/components
- test/functional
5 files changed
+250
-330
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
204 | 204 | | |
205 | 205 | | |
206 | 206 | | |
| 207 | + | |
207 | 208 | | |
208 | 209 | | |
209 | 210 | | |
| |||
0 commit comments