Skip to content

Commit d6dfe7f

Browse files
committed
update test and params
1 parent b0e8c89 commit d6dfe7f

File tree

3 files changed

+16
-14
lines changed

3 files changed

+16
-14
lines changed

packages/compass-data-modeling/src/components/diagram-editor-toolbar.spec.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ describe('DiagramEditorToolbar', function () {
6969
it('renders it active if isInRelationshipDrawingMode is true', function () {
7070
renderDiagramEditorToolbar({ isInRelationshipDrawingMode: true });
7171
const addButton = screen.getByRole('button', {
72-
name: 'Add Relationship',
72+
name: 'Exit Relationship Drawing Mode',
7373
});
7474
expect(addButton).to.have.attribute('aria-pressed', 'true');
7575
});

packages/compass-data-modeling/src/components/diagram-editor.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -157,8 +157,7 @@ const DiagramContent: React.FunctionComponent<{
157157
!!selectedItems &&
158158
selectedItems.type === 'collection' &&
159159
selectedItems.id === coll.ns;
160-
return collectionToDiagramNode({
161-
coll,
160+
return collectionToDiagramNode(coll, {
162161
selectedFields,
163162
selected,
164163
isInRelationshipDrawingMode,

packages/compass-data-modeling/src/utils/nodes-and-edges.tsx

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -142,17 +142,20 @@ export const getFieldsFromSchema = (
142142
return fields;
143143
};
144144

145-
export function collectionToDiagramNode({
146-
coll,
147-
selectedFields = {},
148-
selected = false,
149-
isInRelationshipDrawingMode = false,
150-
}: {
151-
coll: Pick<DataModelCollection, 'ns' | 'jsonSchema' | 'displayPosition'>;
152-
selectedFields?: Record<string, string[][] | undefined>;
153-
selected?: boolean;
154-
isInRelationshipDrawingMode?: boolean;
155-
}): NodeProps {
145+
export function collectionToDiagramNode(
146+
coll: Pick<DataModelCollection, 'ns' | 'jsonSchema' | 'displayPosition'>,
147+
options: {
148+
selectedFields?: Record<string, string[][] | undefined>;
149+
selected?: boolean;
150+
isInRelationshipDrawingMode?: boolean;
151+
} = {}
152+
): NodeProps {
153+
const {
154+
selectedFields = {},
155+
selected = false,
156+
isInRelationshipDrawingMode = false,
157+
} = options;
158+
156159
return {
157160
id: coll.ns,
158161
type: 'collection',

0 commit comments

Comments
 (0)