more error checking and feedback to user

Author: rueckstiess

src/connect/index.jade

@@ -14,8 +14,8 @@
             input.form-control(type='number', name='port', placeholder='27017', data-hook='port')
         .form-group
           label.col-sm-2.control-label Connection Name (optional)
-          a.btn.btn-info.btn-circle.btn-circle-micro(tabindex="0", role="button", data-toggle="popover", data-trigger="focus", title="Connection Name", data-content="You can choose a friendly connection name for this connection, for example \"Development Server\". The connection will appear on the left side under this name.")
-            i.fa.fa-question
+          i.fa.fa-info-circle(tabindex="0", role="button", data-toggle="popover", data-trigger="focus", title="Connection Name", data-content="You can choose a friendly connection name for this connection, for example \"Development Server\". The connection will appear on the left side under this name.")
+            
           .col-sm-10
             input.form-control(type='text', name='name', placeholder='My Localhost', data-hook='name')
         .form-group

src/connect/index.js

@@ -157,12 +157,25 @@ var ConnectView = View.extend({
       + 'under the name "%s". Click "Connect" again to connect to this host.',
         existingConnection.name);
       this.displayedConnection.name = existingConnection.name;
-    } else {
-      // now test if the server is reachable
-      app.statusbar.show();
-      this.message = format('Testing connection...');
-      this.displayedConnection.test(this.onConnectionTested.bind(this));
+      return;
     }
+
+    // now test if the connection name already exists with another uri
+    existingConnection = this.connections.get(this.displayedConnection.name, 'name');
+    if (existingConnection && existingConnection.uri !== this.displayedConnection.uri) {
+      // the connection name exists already, but with a different uri
+      app.statusbar.hide();
+      this.has_error = true;
+      this.message = format('A different connection with the name "%s" already exists. Please '
+      + 'choose a different name.',
+        existingConnection.name);
+      return;
+    }
+
+    // now test if the server is reachable
+    app.statusbar.show();
+    this.message = format('Testing connection...');
+    this.displayedConnection.test(this.onConnectionTested.bind(this));
   },
   onConnectionTested: function(err, model) {
     app.statusbar.hide();

src/models/connection-collection.js

@@ -9,5 +9,6 @@ module.exports = Collection.extend(lodashMixin, restMixin, {
   model: Connection,
   comparator: 'last_used',
   mainIndex: 'uri',
+  indexes: ['name'],
   sync: connectionSync
 });