chore: Unify ts-node/register config in one place; Be more verbose when storing spectron debug metadata (#2421)

* chore: Normalize TS_NODE_FILES usage across packages

* ci(github): Provide a distinct name for spectron debug files based on the os and workflow name

* chore(@mongodb-js/mocha-config-compass): Call register directly and provide options so that packages that depend on it doesn't need to provide env vars manually

Author: gribnoysup

.github/workflows/build.yaml

@@ -104,5 +104,5 @@ jobs:
         uses: actions/upload-artifact@v2
         if: ${{ cancelled() || failure() }}
         with:
-          name: Spectron Debug Log ${{ runner.os }}
+          name: Spectron Debug Files ${{ github.workflow }} ${{ runner.os }}
           path: packages/compass-e2e-tests/.log/**/*

.github/workflows/check-test.yaml

@@ -77,5 +77,5 @@ jobs:
         uses: actions/upload-artifact@v2
         if: ${{ cancelled() || failure() }}
         with:
-          name: Spectron Debug Log ${{ runner.os }}
+          name: Spectron Debug Files ${{ github.workflow }} ${{ runner.os }}
           path: packages/compass-e2e-tests/.log/**/*

configs/mocha-config-compass/index.js

@@ -4,7 +4,7 @@ module.exports = {
   colors: true,
   timeout: 15000,
   require: [
-    'ts-node/register',
+    path.resolve(__dirname, 'tsnode-register.js'),
     path.resolve(__dirname, 'sinon-chai-register.js'),
   ],
   spec: 'src/**/*.spec.*',

configs/mocha-config-compass/tsnode-register.js

@@ -0,0 +1 @@
+require('ts-node').register({ files: true });

packages/compass-components/package.json

@@ -27,7 +27,7 @@
     "check": "npm run lint && npm run depcheck",
     "check-ci": "npm run check",
     "test": "mocha",
-    "test-cov": "cross-env TS_NODE_FILES=true nyc -x \"**/*.spec.*\" npm run test",
+    "test-cov": "nyc -x \"**/*.spec.*\" npm run test",
     "test-watch": "npm run test -- --watch",
     "test-ci": "npm run test-cov",
     "reformat": "npm run prettier -- --write ."

packages/data-service/package.json

@@ -42,8 +42,8 @@
     "lint": "npm run eslint . && npm run prettier -- --check .",
     "check": "npm run lint && npm run depcheck",
     "check-ci": "npm run check",
-    "test": "mocha --timeout 15000 -r ts-node/register **/*.spec.*",
     "pretest": "npm run compile && mongodb-runner start --port=27018 && node ../../scripts/rebuild.js keytar",
+    "test": "mocha",
     "posttest": "mongodb-runner stop --port=27018",
     "test-cov": "nyc -x \"**/*.spec.*\" npm run test",
     "test-watch": "npm run test -- --watch",
@@ -91,7 +91,6 @@
     "rimraf": "^3.0.2",
     "sinon": "^9.2.3",
     "sinon-chai": "^3.5.0",
-    "ts-node": "^10.1.0",
     "typescript": "^4.3.5"
   }
 }

scripts/create-workspace.js

@@ -173,7 +173,7 @@ async function main(argv) {
       'check-ci': 'npm run check',
       test: 'mocha',
       'test-cov':
-        'cross-env TS_NODE_FILES=true nyc -x "**/*.spec.*" npm run test',
+        'nyc -x "**/*.spec.*" npm run test',
       'test-watch': 'npm run test -- --watch',
       'test-ci': 'npm run test-cov',
       reformat: 'npm run prettier -- --write .'
@@ -188,7 +188,6 @@ async function main(argv) {
       '@types/chai': '*',
       '@types/mocha': '*',
       '@types/sinon-chai': '*',
-      'cross-env': '*',
       chai: '*',
       depcheck: '*',
       eslint: '*',