moved func to provider

Author: rubydong

packages/compass-indexes/src/components/create-index-modal/create-index-modal.tsx

@@ -23,13 +23,11 @@ import type { RootState } from '../../modules';
 import {
   useTrackOnChange,
   type TrackFunction,
+  useFireExperimentViewed,
+  TestName,
 } from '@mongodb-js/compass-telemetry/provider';
 import { useConnectionInfoRef } from '@mongodb-js/compass-connections/provider';
 import { usePreference } from 'compass-preferences-model/provider';
-import {
-  useFireExperimentViewed,
-  TestName,
-} from '@mongodb-js/compass-telemetry';
 
 type CreateIndexModalProps = React.ComponentProps<typeof CreateIndexForm> & {
   isVisible: boolean;
@@ -78,14 +76,14 @@ function CreateIndexModal({
   );
 
   // @experiment Early Journey Indexes Guidance & Awareness  | Jira Epic: CLOUDP-239367
-  const enableInIndexesGuidanceExp =
-    usePreference('enableIndexesGuidanceExp') || true;
-  const showIndexesGuidanceVariant =
-    usePreference('showIndexesGuidanceVariant') || true;
+  const enableInIndexesGuidanceExp = usePreference('enableIndexesGuidanceExp');
+  const showIndexesGuidanceVariant = usePreference(
+    'showIndexesGuidanceVariant'
+  );
 
   useFireExperimentViewed({
     testName: TestName.earlyJourneyIndexesGuidance,
-    shouldFire: enableInIndexesGuidanceExp || true,
+    shouldFire: enableInIndexesGuidanceExp,
   });
 
   return (

packages/compass-telemetry/src/growth-experiments.ts

@@ -1,29 +1,3 @@
-import {
-  useTrackOnChange,
-  type TrackFunction,
-} from '@mongodb-js/compass-telemetry/provider';
-
 export enum TestName {
   earlyJourneyIndexesGuidance = 'EARLY_JOURNEY_INDEXES_GUIDANCE_20250328',
 }
-
-export const useFireExperimentViewed = ({
-  testName,
-  shouldFire = true,
-}: {
-  testName: TestName;
-  shouldFire?: boolean;
-}) => {
-  useTrackOnChange(
-    (track: TrackFunction) => {
-      if (!shouldFire) {
-        return;
-      }
-      track('Experiment Viewed', {
-        test_name: testName,
-      });
-    },
-    [],
-    undefined
-  );
-};

packages/compass-telemetry/src/index.ts

@@ -5,4 +5,3 @@ export type {
   IdentifyTraits,
   ExtraConnectionData,
 } from './types';
-export { TestName, useFireExperimentViewed } from './growth-experiments';

packages/compass-telemetry/src/provider.tsx

@@ -3,6 +3,7 @@ import { createServiceLocator } from 'hadron-app-registry';
 import { createTrack, type TelemetryServiceOptions } from './generic-track';
 import { useLogger } from '@mongodb-js/compass-logging/provider';
 import type { TrackFunction } from './types';
+import { TestName } from './growth-experiments';
 
 const noop = () => {
   // noop
@@ -101,4 +102,38 @@ export function useTrackOnChange(
   }, [...dependencies, track, options.skipOnMount]);
 }
 
+/**
+ * Hook that fires Experiment Viewed if user is in an experiment
+ *
+ * @param testName - The name of the experiment to track.
+ * @param shouldFire - A boolean indicating whether to fire the event. Defaults to true.
+ *
+ * @example
+ * useFireExperimentViewed({
+ *   testName: TestName.earlyJourneyIndexesGuidance,
+ *   shouldFire: enableInIndexesGuidanceExp ,
+ * });
+ */
+export const useFireExperimentViewed = ({
+  testName,
+  shouldFire = true,
+}: {
+  testName: TestName;
+  shouldFire?: boolean;
+}) => {
+  useTrackOnChange(
+    (track: TrackFunction) => {
+      if (!shouldFire) {
+        return;
+      }
+      track('Experiment Viewed', {
+        test_name: testName,
+      });
+    },
+    [shouldFire, testName],
+    undefined
+  );
+};
+
 export type { TrackFunction };
+export { TestName };