Skip to content

Commit db1ee5d

Browse files
committed
fixup: update comments
1 parent ed107db commit db1ee5d

File tree

4 files changed

+3
-50
lines changed

4 files changed

+3
-50
lines changed

packages/compass-components/src/components/workspace-tabs/tab.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -149,6 +149,7 @@ const draggingTabStyles = css({
149149
cursor: 'grabbing !important',
150150
});
151151

152+
// TODO: Should this have a dark mode version?
152153
const nonExistentStyles = css({
153154
color: palette.gray.base,
154155
});

packages/compass-components/src/components/workspace-tabs/workspace-tabs.tsx

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -302,29 +302,16 @@ const SortableItem = ({
302302
const tab = useMemo(
303303
() =>
304304
renderTab({
305-
// ...tabProps,
306-
// TODO: id here?
307305
isSelected,
308306
isDragging,
309307
tabContentId: tabId,
310308
onSelect: onTabSelected,
311309
onClose: onTabClosed,
312310
}),
313311
[renderTab]
314-
); // TODO: Add the rest of the tab props. Maybe no useMemo.
312+
);
315313

316314
return tab;
317-
318-
// return tab;(
319-
// <Tab
320-
// {...tabProps}
321-
// isSelected={isSelected}
322-
// isDragging={isDragging}
323-
// tabContentId={tabId}
324-
// onSelect={onTabSelected}
325-
// onClose={onTabClosed}
326-
// />
327-
// );
328315
};
329316

330317
function WorkspaceTabs({

packages/compass-data-modeling/src/index.ts

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,11 @@ import { dataModelStorageServiceLocator } from './provider';
1111
import { activateDataModelingStore } from './store';
1212
import { PluginTabTitle, WorkspaceName } from './plugin-tab-title';
1313

14-
// TODO: Maybe rename to DataModelingPlugin
1514
export const WorkspaceTab: WorkspacePlugin<typeof WorkspaceName> = {
1615
name: WorkspaceName,
1716
provider: registerHadronPlugin(
1817
{
1918
name: 'DataModeling',
20-
// component: DataModelingComponent,
2119
component: function DataModelingProvider({ children }) {
2220
return React.createElement(React.Fragment, null, children);
2321
},
@@ -34,34 +32,4 @@ export const WorkspaceTab: WorkspacePlugin<typeof WorkspaceName> = {
3432
),
3533
content: DataModelingComponent,
3634
header: PluginTabTitle,
37-
// ({
38-
// // todo: type
39-
// id,
40-
// }: {
41-
// id: string;
42-
// }) => ({
43-
// id,
44-
// type: WorkspaceName,
45-
// title: WorkspaceName,
46-
// iconGlyph: 'Diagram' as const,
47-
// }),
4835
};
49-
50-
// export const WorkspaceTab: WorkspaceComponent<typeof WorkspaceName> = {
51-
// name: WorkspaceName,
52-
// provider: DataModelingPlugin,
53-
// content: DataModelingComponent,
54-
// // component: DataModelingPlugin,
55-
// header: ({
56-
// id
57-
// }: {
58-
// id: string;
59-
// }) => ({
60-
// id,
61-
// type: WorkspaceName,
62-
// title: WorkspaceName,
63-
// iconGlyph: 'Diagram' as const,
64-
// })
65-
// };
66-
67-
// export default DataModelingPlugin;

packages/compass-workspaces/src/types.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,6 @@ export type WorkspaceTab = {
8282
id: string;
8383
} & WorkspaceTabProps;
8484

85-
// TODO: Can we remove this type?
8685
export type AnyWorkspace =
8786
| WelcomeWorkspace
8887
| MyQueriesWorkspace
@@ -93,21 +92,19 @@ export type AnyWorkspace =
9392
| CollectionsWorkspace
9493
| CollectionWorkspace;
9594

96-
// TODO: can we remove this type?
9795
export type Workspace<T extends AnyWorkspace['type']> = Extract<
9896
AnyWorkspace,
9997
{ type: T }
10098
>;
10199

102-
// TODO: can we remove this type?
103100
export type WorkspacePluginProps<T extends AnyWorkspace['type']> = Omit<
104101
Workspace<T>,
105102
'type' | 'connectionId'
106103
>;
107104

108105
export type WorkspacePlugin<T extends AnyWorkspace['type']> = {
109106
name: T;
110-
// TODO: How to type the services and activate.
107+
// TODO: Type the services and activate if we can.
111108
// provider: HadronPluginComponent<T, Record<string, () => unknown>, any>;
112109
provider: HadronPluginComponent<WorkspacePluginProps<T>, any, any>;
113110
content:

0 commit comments

Comments
 (0)