Skip to content

Commit dc756fd

Browse files
authored
chore(hadron-build): upload assets to github release in one go (#3334)
Seems like otherwiser we are running into secondary rate limit when trying to do it one by one because every upload first fetches release info. Relevant change in devtools-github-releases package: mongodb-js/devtools-github-repo#3
1 parent 07cda56 commit dc756fd

File tree

3 files changed

+16
-29
lines changed

3 files changed

+16
-29
lines changed

package-lock.json

Lines changed: 8 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/hadron-build/commands/upload.js

Lines changed: 7 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -197,27 +197,14 @@ async function publishGitHubRelease(assets, version, channel, dryRun) {
197197
})
198198
);
199199

200-
const uploads = assetsToUpload.map(async(asset) => {
201-
cli.info(
202-
`${
203-
asset.name
204-
}: upload to Github release ${releaseTag} started (path: ${path.relative(
205-
root,
206-
asset.path
207-
)}).`
208-
);
209-
if (!dryRun) {
210-
await repo.uploadReleaseAsset(releaseTag, {
211-
name: asset.name,
212-
path: asset.path
213-
});
214-
}
215-
cli.info(
216-
`${asset.name}: upload to Github release ${releaseTag} completed.`
217-
);
200+
cli.info(`Uploading ${assetsToUpload.length} asset(s) to GitHub release:`);
201+
assetsToUpload.forEach((asset) => {
202+
cli.info(` - ${path.relative(root, asset.path)}`);
218203
});
219-
220-
await Promise.all(uploads);
204+
if (!dryRun) {
205+
await repo.uploadReleaseAsset(releaseTag, assetsToUpload);
206+
}
207+
cli.info('Asset upload complete');
221208
}
222209

223210
async function uploadAssetsToDownloadCenter(assets, channel, dryRun) {

packages/hadron-build/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
"url": "https://github.com/mongodb-js/compass.git"
2020
},
2121
"dependencies": {
22-
"@mongodb-js/devtools-github-repo": "^1.1.0",
22+
"@mongodb-js/devtools-github-repo": "^1.2.0",
2323
"@mongodb-js/dl-center": "^1.0.1",
2424
"@mongodb-js/electron-wix-msi": "^3.0.0",
2525
"@mongodb-js/mongodb-notary-service-client": "^1.8.0",

0 commit comments

Comments
 (0)