actually auto-update

Author: lerouxb

packages/compass-e2e-tests/helpers/compass.ts

@@ -548,6 +548,8 @@ async function processCommonOpts({
   // Ensure that the user data dir exists
   await fs.mkdir(defaultUserDataDir, { recursive: true });
 
+  console.log({ defaultUserDataDir });
+
   // Chromedriver will fail if log path doesn't exist, webdriver doesn't care,
   // for consistency let's mkdir for both of them just in case
   await fs.mkdir(path.dirname(chromedriverLogPath), { recursive: true });

packages/compass-e2e-tests/smoke-test.ts

@@ -209,7 +209,8 @@ async function run() {
       appName: buildInfo.productName,
       packageFilepath: path.join(compassDir, 'dist', match.filename),
       updatable: match.updatable,
-      // TODO: releaseFilepath once we download the most recent released version too
+      // TODO(COMPASS-8532): releaseFilepath once we download the most recent
+      // released version too
       installer: match.installer,
     };
 
@@ -223,7 +224,8 @@ async function run() {
       console.log(url);
       await downloadFile(url, pkg.packageFilepath);
 
-      // TODO: we need to also download releaseFilepath once we have that
+      // TODO(COMPASS-8532): we need to also download releaseFilepath once we
+      // have that
     }
 
     if (!existsSync(pkg.packageFilepath)) {
@@ -232,20 +234,8 @@ async function run() {
       );
     }
 
-    // TODO: installing either the packaged file or the released file is better
-    // done as part of tests so we can also clean up and install one after the
-    // other, but that's for a separate PR.
-    /*
-    console.log('installing', pkg.packageFilepath);
-    const installedInfo = await pkg.installer({
-      appName: pkg.appName,
-      filepath: pkg.packageFilepath,
-    });
-    console.log('testing', installedInfo.appPath);
-    await testInstalledApp(pkg, installedInfo);
-    */
     await testAutoUpdateFrom(pkg);
-    // TODO:
+    // TODO(COMPASS-8535)
     //await testAutoUpdateTo(pkg);
   } else {
     throw new Error(`${context.package} not implemented`);

packages/compass-e2e-tests/smoketests/auto-update-from.ts

@@ -1,6 +1,7 @@
 import { execute } from '../installers/helpers';
 import type { Package } from '../installers/types';
 
+// TODO: move this since we'll use the same for testing TO
 function testInstalledApp(
   pkg: Package,
   appPath: string,

packages/compass-e2e-tests/tests/auto-update.test.ts

@@ -23,11 +23,17 @@ describe('Auto-update', function () {
       await browser.$(Selectors.AutoUpdateToast).waitForDisplayed();
 
       if (process.env.AUTO_UPDATE_UPDATABLE === 'true') {
-        await browser.$(Selectors.AutoUpdateRestartButton).waitForDisplayed();
+        const restartButton = browser.$(Selectors.AutoUpdateRestartButton);
+        await restartButton.waitForDisplayed();
+
+        // We could click the restart button to apply the update and restart the
+        // app, but restarting the app confuses webdriverio or at least our test
+        // helpers. So we're going to just restart the app manually.
       } else {
-        // When auto-update is not supported the toast contains a link to down
+        // When auto-update is not supported the toast contains a link to
+        // download
         const linkElement = browser.$(Selectors.AutoUpdateDownloadLink);
-        await browser.$(linkElement).waitForDisplayed();
+        await linkElement.waitForDisplayed();
         expect(await linkElement.getAttribute('href')).to.equal(
           'https://www.mongodb.com/try/download/compass'
         );

packages/compass/src/app/index.tsx

@@ -380,8 +380,8 @@ const app = {
     }
 
     if (
-      semver.gt(APP_VERSION, state.previousVersion) &&
-      state.previousVersion !== DEFAULT_APP_VERSION
+      state.previousVersion !== DEFAULT_APP_VERSION &&
+      APP_VERSION !== state.previousVErsion
     ) {
       // Wait a bit before showing the update toast.
       setTimeout(() => {