Skip to content

Commit e0ecbd0

Browse files
authored
fix(connection-form): use a double dash for separating appName identifiers COMPASS-8591 (#6791)
A single `-` can be hard to separate in cases such a vscode where the defaultAppName is `mongodb-vscode` as well as with UUIDs so we use `--` to make this separation clearer.
1 parent 800527f commit e0ecbd0

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

packages/connection-form/src/utils/set-app-name-if-missing.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ describe('setAppNameParamIfMissing', function () {
5757
connectionString: 'mongodb://atlas/',
5858
})
5959
).to.deep.equal({
60-
connectionString: 'mongodb://atlas/?appName=defaultAppName-789-123',
60+
connectionString: 'mongodb://atlas/?appName=defaultAppName--789--123',
6161
});
6262
});
6363
});

packages/connection-form/src/utils/set-app-name-if-missing.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ export function setAppNameParamIfMissing({
2424
if (!searchParams.has('appName') && defaultAppName !== undefined) {
2525
const appName = isAtlas
2626
? `${defaultAppName}${
27-
telemetryAnonymousId ? `-${telemetryAnonymousId}` : ''
28-
}-${connectionId}`
27+
telemetryAnonymousId ? `--${telemetryAnonymousId}` : ''
28+
}--${connectionId}`
2929
: defaultAppName;
3030

3131
searchParams.set('appName', appName);

0 commit comments

Comments
 (0)