Skip to content

Commit e411dd9

Browse files
committed
avoid cyclical dep
1 parent 65b9a9e commit e411dd9

File tree

3 files changed

+19
-14
lines changed

3 files changed

+19
-14
lines changed

package-lock.json

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/compass-collection/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@
5252
"@mongodb-js/compass-app-stores": "^7.59.0",
5353
"@mongodb-js/compass-components": "^1.51.0",
5454
"@mongodb-js/compass-connections": "^1.73.0",
55-
"@mongodb-js/compass-crud": "^13.72.1",
5655
"@mongodb-js/compass-generative-ai": "^0.53.0",
5756
"@mongodb-js/compass-logging": "^1.7.14",
5857
"@mongodb-js/compass-telemetry": "^1.15.0",

packages/compass-collection/src/components/mock-data-generator-modal/raw-schema-confirmation-screen.tsx

Lines changed: 19 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -8,25 +8,31 @@ import {
88
Banner,
99
BannerVariant,
1010
Body,
11+
DocumentList,
1112
} from '@mongodb-js/compass-components';
1213

1314
import { usePreference } from 'compass-preferences-model/provider';
1415
import toSimplifiedFieldInfo from './to-simplified-field-info';
1516
import type { CollectionState } from '../../modules/collection-tab';
1617
import type { SchemaAnalysisState } from '../../schema-analysis-types';
1718
import type { MockDataGeneratorState } from './types';
18-
import { Document } from '@mongodb-js/compass-crud';
19+
import HadronDocument from 'hadron-document';
1920

2021
interface RawSchemaConfirmationScreenProps {
2122
schemaAnalysis: SchemaAnalysisState;
2223
fakerSchemaGenerationStatus: MockDataGeneratorState['status'];
2324
}
2425

25-
const documentContainerStyles = css({
26-
backgroundColor: palette.gray.light3,
27-
border: `1px solid ${palette.gray.light2}`,
28-
borderRadius: spacing[400],
29-
});
26+
// note: the "> div" selector works around the lack of a className prop on HadronDocument
27+
const documentContainerStyles = css`
28+
background-color: ${palette.gray.light3};
29+
border: 1px solid ${palette.gray.light2};
30+
border-radius: ${spacing[400]}px;
31+
32+
> div {
33+
padding: ${spacing[400]}px ${spacing[900]}px;
34+
}
35+
`;
3036

3137
const descriptionStyles = css({
3238
marginBottom: spacing[200],
@@ -65,12 +71,14 @@ const RawSchemaConfirmationScreen = ({
6571
</Body>
6672
<Body className={descriptionStyles}>{descriptionText}</Body>
6773
<div className={documentContainerStyles}>
68-
<Document
74+
<DocumentList.Document
6975
editable={false}
70-
doc={
71-
enableSampleDocumentPassing
72-
? schemaAnalysis.sampleDocument
73-
: toSimplifiedFieldInfo(schemaAnalysis.processedSchema)
76+
value={
77+
new HadronDocument(
78+
enableSampleDocumentPassing
79+
? schemaAnalysis.sampleDocument
80+
: toSimplifiedFieldInfo(schemaAnalysis.processedSchema)
81+
)
7482
}
7583
/>
7684
</div>

0 commit comments

Comments
 (0)