remove TEST_POLLING_INTERVAL

Author: paula-stacho

packages/compass-global-writes/src/store/index.spec.ts

@@ -4,10 +4,10 @@ import { setupStore } from '../../tests/create-store';
 import {
   createShardKey,
   type CreateShardKeyData,
-  TEST_POLLING_INTERVAL,
   unmanageNamespace,
   cancelSharding,
   setPluginTitleVisibility,
+  POLLING_INTERVAL,
 } from './reducer';
 import sinon from 'sinon';
 import type {
@@ -152,6 +152,7 @@ function createStore({
 
 describe('GlobalWritesStore Store', function () {
   let confirmationStub: Sinon.SinonStub;
+  let clock: Sinon.SinonFakeTimers;
 
   beforeEach(() => {
     confirmationStub = sinon
@@ -161,6 +162,7 @@ describe('GlobalWritesStore Store', function () {
 
   afterEach(() => {
     sinon.restore();
+    clock && clock.restore();
   });
 
   it('sets the initial state', function () {
@@ -182,14 +184,17 @@ describe('GlobalWritesStore Store', function () {
       });
 
       // user requests sharding
+      clock = sinon.useFakeTimers({
+        shouldAdvanceTime: true,
+      });
       const promise = store.dispatch(createShardKey(shardKeyData));
       expect(store.getState().status).to.equal('SUBMITTING_FOR_SHARDING');
       await promise;
       expect(store.getState().status).to.equal('SHARDING');
 
       // sharding ends with a shardKey
       mockShardKey = true;
-      await wait(TEST_POLLING_INTERVAL);
+      clock.tick(POLLING_INTERVAL);
       await waitFor(() => {
         expect(store.getState().status).to.equal('SHARD_KEY_CORRECT');
       });
@@ -207,14 +212,17 @@ describe('GlobalWritesStore Store', function () {
       });
 
       // user requests sharding
+      clock = sinon.useFakeTimers({
+        shouldAdvanceTime: true,
+      });
       const promise = store.dispatch(createShardKey(shardKeyData));
       expect(store.getState().status).to.equal('SUBMITTING_FOR_SHARDING');
       await promise;
       expect(store.getState().status).to.equal('SHARDING');
 
       // sharding ends with an error
       mockFailure = true;
-      await wait(TEST_POLLING_INTERVAL);
+      clock.tick(POLLING_INTERVAL);
       await waitFor(() => {
         expect(store.getState().status).to.equal('SHARDING_ERROR');
       });
@@ -240,6 +248,9 @@ describe('GlobalWritesStore Store', function () {
     it('sharding -> valid shard key', async function () {
       let mockShardKey = false;
       // initial state === sharding
+      clock = sinon.useFakeTimers({
+        shouldAdvanceTime: true,
+      });
       const store = createStore({
         isNamespaceManaged: () => true,
         hasShardKey: Sinon.fake(() => mockShardKey),
@@ -251,7 +262,7 @@ describe('GlobalWritesStore Store', function () {
 
       // sharding ends with a shardKey
       mockShardKey = true;
-      await wait(TEST_POLLING_INTERVAL);
+      clock.tick(POLLING_INTERVAL);
       await waitFor(() => {
         expect(store.getState().status).to.equal('SHARD_KEY_CORRECT');
       });
@@ -283,6 +294,9 @@ describe('GlobalWritesStore Store', function () {
       let mockShardKey = false;
       confirmationStub.resolves(true);
       // initial state === sharding
+      clock = sinon.useFakeTimers({
+        shouldAdvanceTime: true,
+      });
       const store = createStore({
         isNamespaceManaged: () => true,
         hasShardKey: Sinon.fake(() => mockShardKey),
@@ -294,13 +308,14 @@ describe('GlobalWritesStore Store', function () {
       // user leaves the workspace
       store.dispatch(setPluginTitleVisibility(false));
       mockShardKey = true;
-      await wait(TEST_POLLING_INTERVAL * 2);
+      clock.tick(POLLING_INTERVAL);
+      clock.tick(POLLING_INTERVAL);
       expect(store.getState().pollingTimeout).to.be.undefined;
       expect(store.getState().status).to.equal('SHARDING'); // no update
 
       // user comes back
       store.dispatch(setPluginTitleVisibility(true));
-      await wait(TEST_POLLING_INTERVAL);
+      await wait(POLLING_INTERVAL);
       await waitFor(() => {
         expect(store.getState().status).to.equal('SHARD_KEY_CORRECT'); // now there is an update
       });

packages/compass-global-writes/src/store/reducer.ts

@@ -6,8 +6,7 @@ import {
 } from '@mongodb-js/compass-components';
 import type { ManagedNamespace } from '../services/atlas-global-writes-service';
 
-const POLLING_INTERVAL = 5000;
-export const TEST_POLLING_INTERVAL = 100;
+export const POLLING_INTERVAL = 5000;
 
 export function isAction<A extends Action>(
   action: Action,
@@ -675,12 +674,9 @@ const pollForShardKey = (): GlobalWritesThunkAction<
     ) {
       return;
     }
-    const timeout = setTimeout(
-      () => {
-        void dispatch(fetchNamespaceShardKey());
-      },
-      process.env.NODE_ENV !== 'test' ? POLLING_INTERVAL : TEST_POLLING_INTERVAL
-    );
+    const timeout = setTimeout(() => {
+      void dispatch(fetchNamespaceShardKey());
+    }, POLLING_INTERVAL);
 
     dispatch({
       type: GlobalWritesActionTypes.NextPollingTimeoutSet,