INT-788 fixes the when "connect to" flashes the previous connect dialog bug

Author: WaleyChen

src/connect/index.js

@@ -438,10 +438,7 @@ var ConnectView = View.extend({
         window.location.origin,
         connection.getId())
     );
-    setTimeout(this.set.bind(this, {
-      message: ''
-    }), 500);
-    setTimeout(window.close, 1000);
+    app.sendMessage('close connect');
   },
 
   /**

src/electron/menu.js

@@ -221,10 +221,7 @@ function darwinMenu(menuState) {
     darwinCompassSubMenu()
   ];
 
-  if (menuState.showConnect) {
-    menu.push(connectSubMenu(false));
-  }
-
+  menu.push(connectSubMenu(false));
   menu.push(editSubMenu());
   menu.push(viewSubMenu());
 
@@ -262,10 +259,6 @@ var MenuState = State.extend({
       type: 'boolean',
       default: false
     },
-    showConnect: {
-      type: 'boolean',
-      default: true
-    },
     showShare: {
       type: 'boolean',
       default: false
@@ -306,7 +299,6 @@ var AppMenu = (function() {
 
       debug('WINDOW\'s ' + winID + ' Menu State');
       debug('showCompassOverview: ' + menuState.showCompassOverview);
-      debug('showConnect: ' + menuState.showConnect);
       debug('showShare: ' + menuState.showShare);
 
       if (process.platform === 'darwin') {
@@ -348,10 +340,6 @@ var AppMenu = (function() {
     },
 
     // share/hide submenu fns
-    hideConnect: function(_window) {
-      this.updateMenu('showConnect', false, _window);
-    },
-
     hideShare: function() {
       this.updateMenu('showShare', false);
     },
@@ -360,10 +348,6 @@ var AppMenu = (function() {
       this.updateMenu('showCompassOverview', true);
     },
 
-    showConnect: function() {
-      this.updateMenu('showConnect', true);
-    },
-
     showShare: function() {
       this.updateMenu('showShare', true);
     },

src/electron/window-manager.js

@@ -86,7 +86,7 @@ module.exports.create = function(opts) {
     url: DEFAULT_URL
   });
 
-  debug('creating new window');
+  debug('creating new window: ' + opts.url);
   var _window = new BrowserWindow({
     width: opts.width,
     height: opts.height,
@@ -136,6 +136,11 @@ function createWindow(opts, url) {
   return module.exports.create(opts);
 }
 
+app.on('close connect', function() {
+  connectWindow.close();
+  connectWindow = null;
+});
+
 app.on('show about dialog', function() {
   dialog.showMessageBox({
     type: 'info',
@@ -155,10 +160,6 @@ app.on('show connect dialog', function(opts) {
     debug('connect window focused.');
     connectWindow.webContents.send('message', 'connect-window-focused');
   });
-  connectWindow.on('closed', function() {
-    debug('connect window closed.');
-    connectWindow = null;
-  });
 });
 
 app.on('hide share submenu', function() {