Use serverSatisfies instead of the connection name

Author: kraenhansen

packages/compass-e2e-tests/helpers/commands/connect.ts

@@ -2,14 +2,14 @@ import {
   DEFAULT_CONNECTION_STRING_1,
   DEFAULT_CONNECTION_NAME_1,
   connectionNameFromString,
+  serverSatisfies,
 } from '../compass';
 import type { CompassBrowser } from '../compass-browser';
 import type { ConnectFormState } from '../connect-form-state';
 import * as Selectors from '../selectors';
 import Debug from 'debug';
 import {
   DEFAULT_CONNECTION_NAMES,
-  isEndOfLifeConnection,
   isTestingAtlasCloudExternal,
   isTestingAtlasCloudSandbox,
 } from '../test-runner-context';
@@ -135,7 +135,7 @@ export async function waitForConnectionResult(
   {
     connectionStatus = 'success',
     timeout,
-    dismissEndOfLifeModal = isEndOfLifeConnection(connectionName),
+    dismissEndOfLifeModal = serverSatisfies('<=4.4'),
   }: ConnectionResultOptions = {}
 ): Promise<string | undefined> {
   const waitOptions = typeof timeout !== 'undefined' ? { timeout } : undefined;

packages/compass-e2e-tests/helpers/test-runner-context.ts

@@ -2,7 +2,6 @@ import {
   getConnectionTitle,
   type ConnectionInfo,
 } from '@mongodb-js/connection-info';
-import { isEndOfLifeVersion } from '@mongodb-js/compass-connections';
 import type { MongoClusterOptions } from 'mongodb-runner';
 import yargs from 'yargs';
 import type { Argv, CamelCase } from 'yargs';
@@ -332,18 +331,6 @@ export function assertTestingAtlasCloudSandbox(
   }
 }
 
-export function isEndOfLifeConnection(connectionName: string) {
-  const connectionIndex = DEFAULT_CONNECTION_NAMES.indexOf(connectionName);
-  const serverInfo = DEFAULT_CONNECTIONS_SERVER_INFO[connectionIndex];
-  if (!serverInfo) {
-    debug(
-      `Unable to find server info for connection named '${connectionName}'`
-    );
-    return false;
-  }
-  return isEndOfLifeVersion(serverInfo.version);
-}
-
 const contextForPrinting = Object.fromEntries(
   Object.entries(context).map(([k, v]) => {
     return [k, /password/i.test(k) ? '<secret>' : v];

packages/compass-e2e-tests/package.json

@@ -32,7 +32,6 @@
   },
   "devDependencies": {
     "@electron/rebuild": "^3.7.2",
-    "@mongodb-js/compass-connections": "^1.56.0",
     "@mongodb-js/compass-test-server": "^0.3.8",
     "@mongodb-js/connection-info": "^0.14.0",
     "@mongodb-js/eslint-config-compass": "^1.3.8",