Skip to content

Commit efc191c

Browse files
committed
fixup! Refactor to a popover
Pass hideCloseButton instead of using display none
1 parent 207bbc1 commit efc191c

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

packages/compass-sidebar/src/components/connections-filter-popover.tsx

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,6 @@ const containerStyles = css({
2323
minWidth: 270,
2424
});
2525

26-
const closeButtonStyles = css({
27-
// An alternative to this is to pass hideCloseButton to InteractivePopover,
28-
// but that throws an error when the popover is opened
29-
display: 'none',
30-
});
31-
3226
const activatedIndicatorStyles = css({
3327
position: 'absolute',
3428
top: spacing[50],
@@ -78,8 +72,8 @@ export default function ConnectionsFilterPopover({
7872
open={open}
7973
setOpen={setOpen}
8074
blurTriggerOnClose
81-
closeButtonClassName={closeButtonStyles}
8275
containerClassName={containerStyles}
76+
hideCloseButton
8377
trigger={({ onClick, children, ref }) => (
8478
<>
8579
<Tooltip

0 commit comments

Comments
 (0)