Merge remote-tracking branch 'origin/main' into eslint-enable-no-unsafe-enum-comparison

Author: gribnoysup

THIRD-PARTY-NOTICES.md

@@ -3,6 +3,7 @@
 const path = require('path');
 const shared = require('@mongodb-js/eslint-config-devtools');
 const common = require('@mongodb-js/eslint-config-devtools/common');
+const chaiFriendly = require('eslint-plugin-chai-friendly');
 
 const extraTsRules = {
   // Newly converted plugins use `any` quite a lot, we can't enable the rule,
@@ -15,28 +16,25 @@ const extraTsRules = {
     'error',
     { fixMixedExportsWithInlineTypeSpecifier: false },
   ],
+  // We use chai outside of tests, hence applying these rules to all ts files
+  ...chaiFriendly.configs.recommended.rules,
   '@typescript-eslint/prefer-promise-reject-errors': 'off',
   '@typescript-eslint/only-throw-error': 'off',
 
   // TODO: a lot new hits with latest typescript-eslint, we should gradually
   // clean those out and re-enable the rules
   '@typescript-eslint/no-explicit-any': 'warn',
   '@typescript-eslint/no-base-to-string': 'warn',
-  '@typescript-eslint/no-require-imports': 'warn',
   '@typescript-eslint/no-unused-vars': [
     'error',
     {
       caughtErrors: 'none', // should be `'all'`
     },
   ],
-  '@typescript-eslint/no-unused-expressions': 'off', // replace with eslint-plugin-chai-friendly
   '@typescript-eslint/no-redundant-type-constituents': 'warn',
   '@typescript-eslint/unbound-method': 'warn',
   '@typescript-eslint/no-duplicate-type-constituents': 'warn',
   '@typescript-eslint/no-unsafe-declaration-merging': 'warn',
-  '@typescript-eslint/no-floating-promises': 'warn',
-  '@typescript-eslint/no-misused-promises': 'warn',
-  '@typescript-eslint/no-duplicate-enum-values': 'warn',
 };
 
 const tsRules = {
@@ -106,7 +104,7 @@ const testTsOverrides = {
 };
 
 module.exports = {
-  plugins: [...shared.plugins, '@mongodb-js/compass'],
+  plugins: [...shared.plugins, '@mongodb-js/compass', 'chai-friendly'],
   rules: {
     ...shared.rules,
     '@mongodb-js/compass/no-leafygreen-outside-compass-components': 'error',

configs/eslint-config-compass/index.js

@@ -22,6 +22,7 @@
     "@typescript-eslint/parser": "^8.34.0",
     "eslint": "^8.57.1",
     "eslint-config-prettier": "^8.3.0",
+    "eslint-plugin-chai-friendly": "^1.1.0",
     "eslint-plugin-filename-rules": "^1.2.0",
     "eslint-plugin-jsx-a11y": "^6.10.2",
     "eslint-plugin-mocha": "^8.0.0",

configs/eslint-config-compass/package.json

@@ -301,7 +301,7 @@ export function createElectronRendererConfig(
 export function createWebConfig(args: Partial<ConfigArgs>): WebpackConfig {
   const opts = webpackArgsWithDefaults(args, { target: 'web' });
 
-  // eslint-disable-next-line @typescript-eslint/no-var-requires
+  // eslint-disable-next-line @typescript-eslint/no-require-imports
   const { peerDependencies } = require(path.join(opts.cwd, 'package.json')) as {
     peerDependencies: Record<string, string>;
   };

configs/webpack-config-compass/src/index.ts

@@ -7,7 +7,7 @@ import { isServe } from './args';
 import chalk from 'chalk';
 
 function isLatestBrowserslist() {
-  // eslint-disable-next-line @typescript-eslint/no-var-requires
+  // eslint-disable-next-line @typescript-eslint/no-require-imports
   const browserslistVersion = require('browserslist/package.json').version;
   const command = `npm view browserslist version --json`;
   const latestBrowserslistVersion = JSON.parse(
@@ -18,7 +18,7 @@ function isLatestBrowserslist() {
 }
 
 const electronVersion = (() => {
-  // eslint-disable-next-line @typescript-eslint/no-var-requires
+  // eslint-disable-next-line @typescript-eslint/no-require-imports
   const [maj, min] = require('electron/package.json').version.split(
     '.'
   ) as string[];

configs/webpack-config-compass/src/loaders.ts

@@ -62,7 +62,7 @@ export function camelCase(str: string): string {
 }
 
 export function getLibraryNameFromCwd(cwd: string): string {
-  // eslint-disable-next-line @typescript-eslint/no-var-requires
+  // eslint-disable-next-line @typescript-eslint/no-require-imports
   const { name, productName } = require(path.join(cwd, 'package.json')) as {
     name: string;
     productName: string;

configs/webpack-config-compass/src/util.ts

@@ -6,7 +6,7 @@
 > the tracking plan for the specific Compass version you can use the following
 > URL: `https://github.com/mongodb-js/compass/blob/<compass version>/docs/tracking-plan.md`
 
-Generated on Fri, Jun 13, 2025
+Generated on Mon, Jun 16, 2025
 
 ## Table of Contents
 
@@ -164,6 +164,7 @@ Generated on Fri, Jun 13, 2025
 - [Code Equivalent Toggled](#event--CreateIndexCodeEquivalentToggled)
 - [Covered Queries Button Clicked](#event--CreateIndexCoveredQueriesButtonClicked)
 - [Covered Queries Learn More Clicked](#event--CreateIndexCoveredQueriesLearnMoreClicked)
+- [ESR Learn More Clicked](#event--CreateIndexESRLearnMoreClicked)
 - [Start with an Index Tab Clicked](#event--CreateIndexIndexTabClicked)
 - [Cancel Button Clicked](#event--CreateIndexModalCancelled)
 - [Create Index Modal Closed](#event--CreateIndexModalClosed)
@@ -1906,6 +1907,15 @@ a system that doesn't offer a suitable secret storage backend.
 - **context** (required): `"Create Index Modal"`
 - **is_compass_web** (optional): `true | undefined`
 
+<a name="event--CreateIndexESRLearnMoreClicked"></a>
+
+### ESR Learn More Clicked
+
+**Properties**:
+
+- **context** (required): `"Create Index Modal"`
+- **is_compass_web** (optional): `true | undefined`
+
 <a name="event--CreateIndexIndexTabClicked"></a>
 
 ### Start with an Index Tab Clicked