chore(e2e): Wait for preferences to be saved before continuing on from browser.closeWelcomeModal() (#5918)

* wait for preferences to be saved when closing the welcome modal

* we probably don't have to skip it on windows now

* rather rely on the side-effect of setting a feature

Author: lerouxb

packages/compass-e2e-tests/helpers/commands/close-welcome-modal.ts

@@ -17,4 +17,11 @@ export async function closeWelcomeModal(
   await welcomeModalElement.waitForDisplayed({
     reverse: true,
   });
+
+  // By setting a feature after closing the welcome modal we know that
+  // preferences will have been saved to disk and therefore showedNetworkOptIn
+  // will have been set to true on disk before we continue. So even if a test
+  // does something like location.reload() immediately it definitely won't show
+  // the welcome modal a second time. It is kinda irrelevant which setting we use.
+  await browser.setFeature('enableShell', true);
 }

packages/compass-e2e-tests/helpers/compass.ts

@@ -1014,6 +1014,7 @@ export async function init(
   if (compass.needsCloseWelcomeModal) {
     await browser.closeWelcomeModal();
   }
+
   if (!opts.noWaitForConnectionScreen) {
     await browser.waitForConnectionScreen();
   }

packages/compass-e2e-tests/tests/auto-connect.test.ts

@@ -190,9 +190,6 @@ describe('Automatically connecting from the command line', function () {
   });
 
   it('enters auto-connect mode again if the window is hard reloaded', async function () {
-    if (process.platform === 'win32' && (process.env.ci || process.env.CI)) {
-      return this.skip(); // Doesn't work on Windows, but only in CI
-    }
     const compass = await init(this.test?.fullTitle(), {
       wrapBinary: positionalArgs([connectionStringSuccess]),
       noWaitForConnectionScreen: true,