Perform dismissal earlier

Author: kraenhansen

packages/compass-e2e-tests/helpers/commands/connect.ts

@@ -140,6 +140,14 @@ export async function waitForConnectionResult(
 ): Promise<string | undefined> {
   const waitOptions = typeof timeout !== 'undefined' ? { timeout } : undefined;
 
+  if (dismissEndOfLifeModal) {
+    await browser.$(Selectors.EndOfLifeConnectionModal).waitForDisplayed();
+    await browser.clickVisible(Selectors.EndOfLifeConnectionModalConfirmButton);
+    await browser
+      .$(Selectors.EndOfLifeConnectionModal)
+      .waitForDisplayed({ reverse: true });
+  }
+
   if (
     (await browser.$(Selectors.SidebarFilterInput).isDisplayed()) &&
     (await browser
@@ -151,14 +159,6 @@ export async function waitForConnectionResult(
     await browser.setValueVisible(Selectors.SidebarFilterInput, '');
   }
 
-  if (dismissEndOfLifeModal) {
-    await browser.$(Selectors.EndOfLifeConnectionModal).waitForDisplayed();
-    await browser.clickVisible(Selectors.EndOfLifeConnectionModalConfirmButton);
-    await browser
-      .$(Selectors.EndOfLifeConnectionModal)
-      .waitForDisplayed({ reverse: true });
-  }
-
   if (connectionStatus === 'either') {
     // For the very rare cases where we don't care whether it fails or succeeds.
     // Usually because the exact result is a race condition.