Skip to content

Commit f488a2c

Browse files
committed
feat(release): write artifacts to new release bucket with private acls COMPASS-9238
This commit adjusts our release process to upload artifacts to the new release bucket using private ACLs. Because users fetch artifacts from our CDN, we are not allowing direct access to this bucket. If we do not set the ACLs to private, our uploads will fail. In order to support this, we had to update to the latest devtools-shared dl-center package.
1 parent 5c8b2ac commit f488a2c

File tree

3 files changed

+10
-8
lines changed

3 files changed

+10
-8
lines changed

package-lock.json

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/hadron-build/lib/download-center.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,9 @@ const getKeyPrefix = (channel) => {
5555
const uploadAssetNew = async (channel, asset) => {
5656
const dlCenterNew = getDownloadCenterNew({ bucket: DOWNLOADS_BUCKET_NEW });
5757
const objectKey = `${getKeyPrefix(channel)}/${asset.name}`;
58-
return dlCenterNew.uploadAsset(objectKey, fs.createReadStream(asset.path));
58+
return dlCenterNew.uploadAsset(objectKey, fs.createReadStream(asset.path), {
59+
acl: 'private',
60+
});
5961
};
6062

6163
const uploadAsset = async (channel, asset) => {

packages/hadron-build/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
"dependencies": {
2222
"@electron/rebuild": "^3.7.1",
2323
"@mongodb-js/devtools-github-repo": "^1.4.1",
24-
"@mongodb-js/dl-center": "^1.2.0",
24+
"@mongodb-js/dl-center": "^1.3.0",
2525
"@mongodb-js/electron-wix-msi": "^3.0.0",
2626
"@mongodb-js/signing-utils": "^0.3.8",
2727
"@npmcli/arborist": "^6.2.0",

0 commit comments

Comments
 (0)