fix(connection-storage): disable ampersand validations COMPASS-5968 (#3263)

* fix(connection-storage):  disable ampersand validations

* update test title

Author: mcasimir

packages/data-service/src/connection-storage.spec.ts

@@ -374,6 +374,32 @@ describe('ConnectionStorage', function () {
         });
       });
     });
+
+    it('does not trigger old connection-model validations', async function () {
+      const connectionStorage = new ConnectionStorage();
+      const id = uuid();
+      await connectionStorage.save({
+        id,
+        connectionOptions: {
+          connectionString:
+            'mongodb://localhost:27017/?tls=true&tlsCertificateKeyFile=%2FUsers%2Fmaurizio%2FDownloads%2FX509-cert-2577072670755779500.pem',
+        },
+      });
+
+      await eventually(() => {
+        const { connectionInfo } = JSON.parse(
+          fs.readFileSync(getConnectionFilePath(tmpDir, id), 'utf-8')
+        );
+
+        expect(connectionInfo).to.deep.equal({
+          id,
+          connectionOptions: {
+            connectionString:
+              'mongodb://localhost:27017/?tls=true&tlsCertificateKeyFile=%2FUsers%2Fmaurizio%2FDownloads%2FX509-cert-2577072670755779500.pem',
+          },
+        });
+      });
+    });
   });
 
   describe('destroy', function () {

packages/data-service/src/connection-storage.ts

@@ -79,6 +79,7 @@ export class ConnectionStorage {
         model.save(undefined, {
           success: resolve,
           error: reject,
+          validate: false,
         });
       });
     } catch (err) {

packages/data-service/src/legacy/legacy-connection-model.ts

@@ -156,6 +156,7 @@ export interface LegacyConnectionModelProperties {
 export interface AmpersandMethodOptions<T> {
   success: (model: T) => void;
   error: (model: T, error: Error) => void;
+  validate?: boolean;
 }
 
 export interface LegacyConnectionModel extends LegacyConnectionModelProperties {