Commit f5b2c3f
committed
Backport: COMPASS-132 Fix Intercom email can't be blank error (#534)
The below started appearing when intercom messenger was upgraded
several weeks ago. The root cause is user resource would send
`email:‘’` which fails validation on Intercom's API server. If we
instead allow email to default to undefined, no empty string is sent to
intercom’s server and validation passes. After this is merged, we’ll
also need to change models/user.js in Compass.
```
Failed to load resource: the server responded with a status of 400 (Bad
Request)
Uncaught (in promise
{"type":"error.list","request_id":"anscsvqg0eamtn7i98t0","errors":[{"cod
e":"parameter_invalid","message":"Email can't be blank"}]}
```1 parent 77bb403 commit f5b2c3f
2 files changed
+7
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
128 | 128 | | |
129 | 129 | | |
130 | 130 | | |
131 | | - | |
| 131 | + | |
132 | 132 | | |
133 | 133 | | |
134 | 134 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
26 | 31 | | |
27 | 32 | | |
28 | 33 | | |
| |||
0 commit comments