Skip to content

Commit f74fa08

Browse files
committed
more cleanup
1 parent 8ef919b commit f74fa08

File tree

4 files changed

+0
-63
lines changed

4 files changed

+0
-63
lines changed

package-lock.json

Lines changed: 0 additions & 30 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/compass/package.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -259,16 +259,13 @@
259259
"hadron-app-registry": "^9.4.9",
260260
"hadron-build": "^25.7.11",
261261
"hadron-ipc": "^3.4.8",
262-
"local-links": "^1.4.0",
263262
"make-fetch-happen": "^10.2.1",
264-
"marky": "^1.2.1",
265263
"minimatch": "^10.0.1",
266264
"mongodb": "^6.16.0",
267265
"mongodb-build-info": "^1.7.2",
268266
"mongodb-cloud-info": "^2.1.7",
269267
"mongodb-connection-string-url": "^3.0.1",
270268
"mongodb-data-service": "^22.27.0",
271-
"mongodb-instance-model": "^12.30.0",
272269
"mongodb-log-writer": "^2.3.4",
273270
"mongodb-ns": "^2.4.2",
274271
"react": "^17.0.2",

packages/compass/src/app/application.tsx

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import { CompassElectron } from './components/entrypoint';
88
import { openToast, ToastBody } from '@mongodb-js/compass-components';
99
import ensureError from 'ensure-error';
1010

11-
import * as marky from 'marky';
1211
import * as webvitals from 'web-vitals';
1312
import React from 'react';
1413
import ReactDOM from 'react-dom';
@@ -126,21 +125,6 @@ class Application {
126125
}
127126
}
128127

129-
/**
130-
* Pre-load into the require cache a bunch of expensive modules while the
131-
* user is choosing which connection, so when the user clicks on Connect,
132-
* Compass can connect to the MongoDB instance faster.
133-
*/
134-
private preloadSlowModules() {
135-
marky.mark('Pre-loading additional modules required to connect');
136-
// Seems like this doesn't have as much of an effect as we'd hoped as
137-
// most of the expense has already occurred. You can see it take 1700ms
138-
// or so if you move this to the top of the file.
139-
require('local-links');
140-
require('mongodb-instance-model');
141-
marky.stop('Pre-loading additional modules required to connect');
142-
}
143-
144128
/**
145129
* Called a soon as the DOM is ready so we can
146130
* start showing status indicators as
@@ -466,9 +450,6 @@ class Application {
466450
}
467451

468452
async init() {
469-
marky.mark('Time to Connect rendered');
470-
marky.mark('Time to user can Click Connect');
471-
472453
// Setup global error handling first to ensure all
473454
// unhandled errors are properly logged and reported
474455
this.setupGlobalErrorHandling();
@@ -498,11 +479,6 @@ class Application {
498479

499480
// Render the application
500481
await this.render();
501-
marky.stop('Time to Connect rendered');
502-
503-
// Preload modules and complete initialization
504-
this.preloadSlowModules();
505-
marky.stop('Time to user can Click Connect');
506482

507483
// Throws a synthetic exception for e2e tests so we can test the handling
508484
// of uncaught exceptions.

packages/compass/src/index.d.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,3 @@ declare module 'process' {
4242
}
4343
}
4444
}
45-
46-
declare module 'marky' {
47-
declare function mark(label: string): void;
48-
declare function stop(label: string): void;
49-
export { mark, stop };
50-
}

0 commit comments

Comments
 (0)