Dont use schema in community (#1269)

Author: durran

src/app/index.js

@@ -20,10 +20,6 @@ require('./setup-hadron-caches');
 /**
  * The main entrypoint for the application!
  */
-const pkg = require('../../package.json');
-const COMMUNITY = 'mongodb-compass-community';
-const DISTRIBUTION = pkg.config.hadron.distributions[process.env.HADRON_DISTRIBUTION];
-
 var electron = require('electron');
 var APP_VERSION = electron.remote.app.getVersion();
 
@@ -227,7 +223,7 @@ var Application = View.extend({
      * If we're in Compass community and the license has not been agreed, we need
      * to show it first and force the user to agree or disagree.
      */
-    if (DISTRIBUTION.name === COMMUNITY && !app.preferences.agreedToLicense) {
+    if (process.env.HADRON_PRODUCT === 'mongodb-compass-community' && !app.preferences.agreedToLicense) {
       const licenseComponent = app.appRegistry.getRole('Application.License')[0].component;
       const licenseStore = app.appRegistry.getStore('License.Store');
       const licenseActions = app.appRegistry.getAction('License.Actions');
@@ -324,7 +320,7 @@ var Application = View.extend({
         prefs.lastKnownVersion = currentVersion;
         save = true;
       }
-      if (DISTRIBUTION.name === COMMUNITY) {
+      if (process.env.HADRON_PRODUCT === 'mongodb-compass-community') {
         prefs.enableMaps = false;
         prefs.enableFeedbackPanel = false;
         save = true;

src/app/network-optin/index.js

@@ -7,10 +7,6 @@ var debug = require('debug')('mongodb-compass:network-optin:index');
 
 var indexTemplate = require('./index.jade');
 
-const pkg = require('../../../package.json');
-const COMMUNITY = 'mongodb-compass-community';
-const DISTRIBUTION = pkg.config.hadron.distributions[process.env.HADRON_DISTRIBUTION];
-
 var NetworkOptInView = View.extend({
   template: indexTemplate,
   props: {
@@ -30,7 +26,7 @@ var NetworkOptInView = View.extend({
     isCommunity: {
       type: 'boolean',
       required: true,
-      default: DISTRIBUTION.name === COMMUNITY
+      default: process.env.HADRON_PRODUCT === 'mongodb-compass-community'
     }
   },
   events: {

src/app/tour/index.js

@@ -17,10 +17,6 @@ var TAB_KEY = 9;
 var ENTER_KEY = 13;
 var SPACE_KEY = 32;
 
-const pkg = require('../../../package.json');
-const COMMUNITY = 'mongodb-compass-community';
-const DISTRIBUTION = pkg.config.hadron.distributions[process.env.HADRON_DISTRIBUTION];
-
 /**
  * The feature tour highlights some signature features of MongoDB Compass.
  * When Compass is started for the first time, it shows all the features in
@@ -122,7 +118,7 @@ var TourView = View.extend({
     var previous = model.previousVersion || '0.0.0';
 
     model.features = _.filter(FEATURES, function(feature) {
-      if (DISTRIBUTION.name === COMMUNITY && !feature.community) {
+      if (process.env.HADRON_PRODUCT === 'mongodb-compass-community' && !feature.community) {
         return false;
       }
       if (model.force && feature.initial) {

src/app/tour/index.less

@@ -9,7 +9,7 @@
   left: 0;
   right: 0;
   bottom: 0;
-  z-index: 20;
+  z-index: 200;
 }
 #tour-bg {
   position: absolute;
@@ -26,6 +26,7 @@
   left: 50%;
   width: 90%;
   max-width: 1100px;
+  z-index: 1000;
   position: absolute;
   background-color: @pw;
   -webkit-transform: translate(-50%, -50%);

src/internal-plugins/metrics/lib/setup.js

@@ -14,9 +14,6 @@ const ICON_PATH = path.join(__dirname, '..', 'images', 'compass-dialog-icon.png'
 
 const debug = require('debug')('mongodb-compass:metrics:setup');
 
-const COMMUNITY = 'mongodb-compass-community';
-const DISTRIBUTION = pkg.config.hadron.distributions[process.env.HADRON_DISTRIBUTION];
-
 const INTERCOM_KEY = 'p57suhg7';
 const BUGSNAG_KEY = '0d11ab5f4d97452cc83d3365c21b491c';
 
@@ -38,7 +35,7 @@ module.exports = function() {
     }
   });
 
-  if (DISTRIBUTION.name !== COMMUNITY) {
+  if (process.env.HADRON_PRODUCT !== 'mongodb-compass-community') {
     metrics.configure({
       intercom: {
         appId: INTERCOM_KEY,
@@ -143,7 +140,7 @@ module.exports = function() {
    * such that when a link is clicked, the event is properly
    * passed off to `app.router` and a web page actually opens.
    */
-  if (DISTRIBUTION.name !== COMMUNITY) {
+  if (process.env.HADRON_PRODUCT !== 'mongodb-compass-community') {
     intercom.configure();
   }
 

src/internal-plugins/schema/index.js

@@ -1,4 +1,3 @@
-const app = require('hadron-app');
 const SchemaComponent = require('./lib/component');
 const SchemaStatusSubview = require('./lib/component/status-subview');
 const SchemaAction = require('./lib/action');
@@ -17,23 +16,30 @@ const COLLECTION_TAB_ROLE = {
 /**
  * Activate all the components in the Schema package.
  *
- * @param {Object} appRegistry   the app registry
+ * @param {Object} appRegistry - the app registry
  */
 function activate(appRegistry) {
-  appRegistry.registerRole('Collection.Tab', COLLECTION_TAB_ROLE);
-  appRegistry.registerAction('Schema.Actions', SchemaAction);
-  appRegistry.registerStore('Schema.Store', SchemaStore);
-  appRegistry.registerComponent('Schema.StatusSubview', SchemaStatusSubview);
+  // @todo: Temporary hack to remove the internal plugin from the community edition.
+  if (process.env.HADRON_PRODUCT !== 'mongodb-compass-community') {
+    appRegistry.registerRole('Collection.Tab', COLLECTION_TAB_ROLE);
+    appRegistry.registerAction('Schema.Actions', SchemaAction);
+    appRegistry.registerStore('Schema.Store', SchemaStore);
+    appRegistry.registerComponent('Schema.StatusSubview', SchemaStatusSubview);
+  }
 }
 
 /**
  * Deactivate all the components in the Schema package.
+ *
+ * @param {Object} appRegistry - the app registry
  */
-function deactivate() {
-  app.appRegistry.deregisterRole('Collection.Tab', COLLECTION_TAB_ROLE);
-  app.appRegistry.deregisterAction('Schema.Actions');
-  app.appRegistry.deregisterStore('Schema.Store');
-  app.appRegistry.deregisterComponent('Schema.StatusSubview');
+function deactivate(appRegistry) {
+  if (process.env.HADRON_PRODUCT !== 'mongodb-compass-community') {
+    appRegistry.deregisterRole('Collection.Tab', COLLECTION_TAB_ROLE);
+    appRegistry.deregisterAction('Schema.Actions');
+    appRegistry.deregisterStore('Schema.Store');
+    appRegistry.deregisterComponent('Schema.StatusSubview');
+  }
 }
 
 module.exports.activate = activate;

src/main/menu.js

@@ -6,15 +6,12 @@ var ipc = require('hadron-ipc');
 var BrowserWindow = electron.BrowserWindow;
 var Menu = electron.Menu;
 var app = electron.app;
-var pkg = require('../../package.json');
 
 var State = require('ampersand-state');
 var _ = require('lodash');
 var debug = require('debug')('mongodb-compass:menu');
 
 const COMPASS_HELP = 'https://docs.mongodb.com/compass/';
-const COMMUNITY = 'mongodb-compass-community';
-const DISTRIBUTION = pkg.config.hadron.distributions[process.env.HADRON_DISTRIBUTION];
 
 // submenu related
 function separator() {
@@ -189,7 +186,7 @@ function helpSubMenu() {
   subMenu.push(securityItem());
 
 
-  if (!DISTRIBUTION || (DISTRIBUTION.name !== COMMUNITY)) {
+  if (process.env.HADRON_PRODUCT !== 'mongodb-compass-community') {
     subMenu.push(separator());
     subMenu.push(intercomItem());
   }

src/setup-hadron-distribution.js

@@ -5,9 +5,13 @@ const pkg = require('../package.json');
  * npm start compass-community
  */
 if (!process.env.HADRON_DISTRIBUTION) {
-  process.env.HADRON_DISTRIBUTION = pkg.distribution || pkg.config.hadron.distributions.default;
+  const distribution = pkg.distribution || pkg.config.hadron.distributions.default;
+  process.env.HADRON_DISTRIBUTION = distribution;
 }
 
+const name = pkg.config.hadron.distributions[process.env.HADRON_DISTRIBUTION].name;
+process.env.HADRON_PRODUCT = name || 'mongodb-compass';
+
 if (pkg.distribution) {
   process.env.NODE_ENV = 'production';
 }