make copilot happy

lerouxb · lerouxb · commit f9eb82f6d991 · 2025-09-22T13:39:20.000+01:00
diff --git a/packages/compass-components/src/components/drawer-portal.tsx b/packages/compass-components/src/components/drawer-portal.tsx
@@ -301,7 +301,8 @@ export const DrawerAnchor: React.FunctionComponent = ({ children }) => {
       }
 
       setAssistantNodes((oldNodes) => {
-        for (const id of Object.keys({ ...nodes, oldNodes })) {
+        // account for removed nodes by checking all keys of both old and new
+        for (const id of Object.keys({ ...oldNodes, nodes })) {
           if (nodes[id] !== oldNodes[id]) {
             return nodes;
           }

Original file line number	Diff line number	Diff line change
`@@ -301,7 +301,8 @@ export const DrawerAnchor: React.FunctionComponent = ({ children }) => {`
`301`	`301`	`}`
`302`	`302`
`303`	`303`	`setAssistantNodes((oldNodes) => {`
`304`		`- for (const id of Object.keys({ ...nodes, oldNodes })) {`
	`304`	`+ // account for removed nodes by checking all keys of both old and new`
	`305`	`+ for (const id of Object.keys({ ...oldNodes, nodes })) {`
`305`	`306`	`if (nodes[id] !== oldNodes[id]) {`
`306`	`307`	`return nodes;`
`307`	`308`	`}`