Merge remote-tracking branch 'origin/main' into electron-32

Author: addaleax

.depalignrc.json

@@ -26,6 +26,9 @@
     ],
     "js-yaml": [
       "^3.13.1"
+    ],
+    "yargs": [
+      "^4.8.1"
     ]
   }
 }

.evergreen/functions.yml

@@ -597,10 +597,9 @@ functions:
           DEBUG: ${debug|}
           MONGODB_VERSION: ${mongodb_version|}
           MONGODB_RUNNER_VERSION: ${mongodb_version|}
-          E2E_TEST_GROUPS: ${e2e_test_groups}
-          E2E_TEST_GROUP: ${e2e_test_group}
+          COMPASS_E2E_TEST_GROUPS: ${e2e_test_groups}
+          COMPASS_E2E_TEST_GROUP: ${e2e_test_group}
           ATLAS_LOCAL_VERSION: latest
-          HADRON_DISTRIBUTION: compass
         script: |
           set -e
           # Load environment variables
@@ -629,8 +628,8 @@ functions:
           DEBUG: ${debug|}
           MONGODB_VERSION: ${mongodb_version|}
           MONGODB_RUNNER_VERSION: ${mongodb_version|}
-          E2E_TEST_GROUPS: ${e2e_test_groups}
-          E2E_TEST_GROUP: ${e2e_test_group}
+          COMPASS_E2E_TEST_GROUPS: ${e2e_test_groups}
+          COMPASS_E2E_TEST_GROUP: ${e2e_test_group}
         script: |
           set -e
           # Load environment variables
@@ -664,14 +663,14 @@ functions:
           DEBUG: ${debug|}
           MONGODB_VERSION: ${mongodb_version|}
           MONGODB_RUNNER_VERSION: ${mongodb_version|}
-          COMPASS_WEB_BROWSER_NAME: ${browser_name}
-          E2E_TEST_GROUPS: ${e2e_test_groups}
-          E2E_TEST_GROUP: ${e2e_test_group}
+          COMPASS_E2E_BROWSER_NAME: ${browser_name}
+          COMPASS_E2E_TEST_GROUPS: ${e2e_test_groups}
+          COMPASS_E2E_TEST_GROUP: ${e2e_test_group}
         script: |
           set -e
           # Load environment variables
           eval $(.evergreen/print-compass-env.sh)
-          npm run --unsafe-perm --workspace compass-e2e-tests test-web
+          npm run --unsafe-perm --workspace compass-e2e-tests test-ci web
 
   test-connectivity:
     - command: shell.exec

.github/workflows/check-pr-title.yml

@@ -0,0 +1,24 @@
+name: "Check PR Title"
+on:
+  pull_request:
+    types: [opened, synchronize, reopened, ready_for_review, labeled, unlabeled, converted_to_draft, edited]
+
+jobs:
+  check-pr-title:
+    name: Check PR Title
+    runs-on: ubuntu-latest
+    steps:
+      - name: Enforce conventional commit style
+        uses: realm/ci-actions/title-checker@main
+        with:
+          regex: '^(build|chore|ci|docs|feat|fix|perf|refactor|revert|style|test|ops){1}(\([\w\-\.]+\))?(!)?: .*'
+          error-hint: 'Invalid PR title. Make sure it follows the conventional commit specification (i.e. "<type>(<optional scope>): <description>") or add the no-title-validation label'
+          ignore-labels: 'no-title-validation'
+      - name: Enforce JIRA ticket in title
+        uses: realm/ci-actions/title-checker@main
+        # Skip the JIRA ticket check for PRs opened by bots
+        if: ${{ !contains(github.event.pull_request.user.login, '[bot]') }}
+        with:
+          regex: '[A-Z]{4,10}-[0-9]{1,5}$'
+          error-hint: 'Invalid PR title. Make sure it ends with a JIRA ticket - i.e. COMPASS-1234 or add the no-title-validation label'
+          ignore-labels: 'no-title-validation'

AUTHORS

@@ -93,3 +93,4 @@ Kræn Hansen <[email protected]>
 Kræn Hansen <[email protected]>
 Ruchitha Rajaghatta <[email protected]>
 syn-zhu <[email protected]>
+Nikola Irinchev <[email protected]>

THIRD-PARTY-NOTICES.md

@@ -1,5 +1,5 @@
 The following third-party software is used by and included in **Mongodb Compass**.
-This document was automatically generated on Thu Oct 24 2024.
+This document was automatically generated on Mon Oct 28 2024.
 
 ## List of dependencies
 

docs/tracking-plan.md

@@ -1,7 +1,7 @@
 
 # Compass Tracking Plan
 
-Generated on Thu, Oct 24, 2024 at 09:52 AM
+Generated on Mon, Oct 28, 2024 at 12:44 PM
 
 ## Table of Contents
 

package-lock.json

@@ -4,7 +4,10 @@ import type { CompassBrowser } from '../compass-browser';
 import * as Selectors from '../selectors';
 import type { ConnectFormState } from '../connect-form-state';
 import Debug from 'debug';
-import { DEFAULT_CONNECTIONS } from '../test-runner-context';
+import {
+  DEFAULT_CONNECTIONS,
+  isTestingAtlasCloudExternal,
+} from '../test-runner-context';
 import { getConnectionTitle } from '@mongodb-js/connection-info';
 const debug = Debug('compass-e2e-tests');
 
@@ -925,6 +928,12 @@ export async function saveConnection(
 }
 
 export async function setupDefaultConnections(browser: CompassBrowser) {
+  // When running tests against Atlas Cloud, connections can't be added or
+  // removed from the UI manually, so we skip setup for default connections
+  if (isTestingAtlasCloudExternal()) {
+    return;
+  }
+
   /*
   This is intended to be used by most test files (ones that don't care too much
   about the intricacies about connections) in a before() hook after starting

packages/compass-e2e-tests/helpers/commands/connect-form.ts

@@ -1,6 +1,6 @@
 import path from 'path';
 import type { CompassBrowser } from '../compass-browser';
-import { LOG_SCREENSHOTS_PATH } from '../test-runner-context';
+import { LOG_SCREENSHOTS_PATH } from '../test-runner-paths';
 
 const withTimeout = (millis: number, promise: Promise<any>) => {
   let timeoutPid: NodeJS.Timeout;