Skip to content

Commit fda1d08

Browse files
committed
simplifiedexperiment viewed func
1 parent 4a08032 commit fda1d08

File tree

2 files changed

+20
-20
lines changed

2 files changed

+20
-20
lines changed

packages/compass-indexes/src/components/create-index-modal/create-index-modal.tsx

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -80,17 +80,10 @@ function CreateIndexModal({
8080
'showIndexesGuidanceVariant'
8181
);
8282

83-
useTrackOnChange(
84-
(track: TrackFunction) => {
85-
fireExperimentViewed({
86-
track,
87-
testName: TestName.earlyJourneyIndexesGuidance,
88-
shouldFire: enableInIndexesGuidanceExp,
89-
});
90-
},
91-
[enableInIndexesGuidanceExp],
92-
undefined
93-
);
83+
fireExperimentViewed({
84+
testName: TestName.earlyJourneyIndexesGuidance,
85+
shouldFire: enableInIndexesGuidanceExp || true,
86+
});
9487

9588
return (
9689
<Modal
Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,29 @@
1-
import { type TrackFunction } from '@mongodb-js/compass-telemetry/provider';
1+
import {
2+
useTrackOnChange,
3+
type TrackFunction,
4+
} from '@mongodb-js/compass-telemetry/provider';
25

36
export enum TestName {
47
earlyJourneyIndexesGuidance = 'EARLY_JOURNEY_INDEXES_GUIDANCE_20250328',
58
}
69

710
export const fireExperimentViewed = ({
8-
track,
911
testName,
1012
shouldFire = true,
1113
}: {
12-
track: TrackFunction;
1314
testName: TestName;
1415
shouldFire?: boolean;
1516
}) => {
16-
if (!shouldFire) {
17-
return;
18-
}
19-
track('Experiment Viewed', {
20-
test_name: testName,
21-
});
17+
useTrackOnChange(
18+
(track: TrackFunction) => {
19+
if (!shouldFire) {
20+
return;
21+
}
22+
track('Experiment Viewed', {
23+
test_name: testName,
24+
});
25+
},
26+
[],
27+
undefined
28+
);
2229
};

0 commit comments

Comments
 (0)