do mix with adapt ns info

Author: mabaasit

packages/data-service/src/data-service.ts

@@ -1179,7 +1179,6 @@ class DataServiceImpl extends WithLogContext implements DataService {
       adaptCollectionInfo({
         db: dbName,
         ...collInfo,
-        is_non_existent: false,
       }) ?? null
     );
   }
@@ -1352,7 +1351,10 @@ class DataServiceImpl extends WithLogContext implements DataService {
       // if they were fetched successfully
       [...collectionsFromPrivileges, ...listedCollections],
       'name'
-    ).map((coll) => adaptCollectionInfo({ db: databaseName, ...coll }));
+    ).map(({ is_non_existent, ...coll }) => ({
+      is_non_existent,
+      ...adaptCollectionInfo({ db: databaseName, ...coll }),
+    }));
 
     return collections;
   }
@@ -1455,10 +1457,11 @@ class DataServiceImpl extends WithLogContext implements DataService {
       // if they were fetched successfully
       [...databasesFromRoles, ...databasesFromPrivileges, ...listedDatabases],
       'name'
-    ).map(({ name, ...db }) => {
+    ).map(({ name, is_non_existent, ...db }) => {
       return {
         _id: name,
         name,
+        is_non_existent,
         ...adaptDatabaseInfo(db),
       };
     });

packages/data-service/src/instance-detail-helper.ts

@@ -359,17 +359,15 @@ function adaptBuildInfo(rawBuildInfo: Partial<BuildInfo>) {
 }
 
 export function adaptDatabaseInfo(
-  databaseStats: Partial<DbStats> &
-    Partial<DatabaseInfo> & { is_non_existent: boolean }
-): Omit<DatabaseDetails, '_id' | 'collections' | 'name'> {
+  databaseStats: Partial<DbStats> & Partial<DatabaseInfo>
+): Omit<DatabaseDetails, '_id' | 'collections' | 'name' | 'is_non_existent'> {
   return {
     collection_count: databaseStats.collections ?? 0,
     document_count: databaseStats.objects ?? 0,
     index_count: databaseStats.indexes ?? 0,
     storage_size: databaseStats.storageSize ?? 0,
     data_size: databaseStats.dataSize ?? 0,
     index_size: databaseStats.indexSize ?? 0,
-    is_non_existent: databaseStats.is_non_existent,
   };
 }
 
@@ -379,12 +377,10 @@ export function adaptCollectionInfo({
   info,
   options,
   type,
-  is_non_existent,
 }: CollectionInfoNameOnly &
   Partial<CollectionInfo> & {
     db: string;
-    is_non_existent: boolean;
-  }): CollectionDetails {
+  }): Omit<CollectionDetails, 'is_non_existent'> {
   const ns = toNS(`${db}.${name}`);
   const {
     collection,
@@ -432,6 +428,5 @@ export function adaptCollectionInfo({
     validation: hasValidation
       ? { validator, validationAction, validationLevel }
       : null,
-    is_non_existent,
   };
 }